From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string Date: Mon, 23 Mar 2015 10:15:06 +0100 Message-ID: <20150323091506.GA17225@aepfle.de> References: <1426872279-5001-1-git-send-email-olaf@aepfle.de> <1426872279-5001-5-git-send-email-olaf@aepfle.de> <550FDEB2020000780006C785@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <550FDEB2020000780006C785@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Wei Liu , Ian Campbell , Stefano Stabellini , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org, Keir Fraser List-Id: xen-devel@lists.xenproject.org On Mon, Mar 23, Jan Beulich wrote: > >>> On 20.03.15 at 18:24, wrote: > > To allow reproducible builds of hvmloader introduce a make variable > > SMBIOS_REL_DATE=mm/dd/yyyy to provide a fixed date string. Without this > > change the hvmloader binary changes with every rebuild. > > I don't really object to this change, but didn't we discuss using > smbios.c's time stamp instead, which then would properly reflect > eventual changes during incremental builds along with producing > unchanged output when there hasn't been any change? Using the file timestamp will actually break the attempt to get a reproducible build if the file is patched during package build. With each rebuild patch(1) will alter the timestamp. Olaf