From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YZz2x-0006Jj-0f
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 05:53:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YZz2t-0008Dw-RM
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 05:53:22 -0400
Received: from smtp3.mundo-r.com ([212.51.32.191]:58743 helo=smtp4.mundo-r.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YZz2t-0008Da-L9
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 05:53:19 -0400
Date: Mon, 23 Mar 2015 10:53:11 +0100
From: Alberto Garcia <berto@igalia.com>
Message-ID: <20150323095311.GA18824@igalia.com>
References: <cover.1426861657.git.berto@igalia.com>
	<cover.1426861657.git.berto@igalia.com>
	<761b091f1fa10354f9594cf7a867cf6eb2701b1f.1426861657.git.berto@igalia.com>
	<87egogt6hs.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87egogt6hs.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to
 BLOCK_IMAGE_CORRUPTED
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

On Mon, Mar 23, 2015 at 10:20:31AM +0100, Markus Armbruster wrote:

> > +- "device":    Device name (json-string)
> > +- "node-name": Node name, if it's present (json-string)
> 
> By convention, we mark optional members like this:
> 
> - "node-name": Node name (json-string, optional)

You're right, thanks for pointing that out!

This can be fixed when committing the patch, otherwise I can resend
the series again.

> Ignorant question: can "device" be ""? If yes, we should document
> what that means, possibly in a separate patch.

Yes it can be "", the purpose of the patch is precisely to expand the
event with a new field that can identify the node in such cases.

The only reason why it is not optional is to keep backward
compatibility.

But it's true that it can be clarified in the documentation, I can
send a follow-up patch as soon as this one is merged.

Berto