All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	aaro.koskinen@iki.fi, pauldaviesc@gmail.com,
	nitinkuppelur@gmail.com, linux-kernel@vger.kernel.org,
	br@ahlamon.org
Subject: Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket
Date: Mon, 23 Mar 2015 13:40:06 +0300	[thread overview]
Message-ID: <20150323104006.GZ10964@mwanda> (raw)
In-Reply-To: <1427069076-26720-1-git-send-email-xerofoify@gmail.com>

On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
> Fixes the checkpath.pl error where the opening bracket has a unneeded space between
> it and the function name for a if statement in the marco,VMX_WAIT_FOR_FIELD32.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..0408a12 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -412,7 +412,7 @@ struct octeon_hcd {
>  		type c;							    \
>  		while (1) {						    \
>  			c.u32 = __cvmx_usb_read_csr32(usb, address);	    \
> -			if (c.s.field op (value)) {			    \
> +			if (c.s.field op(value)) {			    \

"op" is not a function here.  This is macro and top is an operation like
"+" or "*".  So checkpatch.pl is wrong.

regards,
dan carpenter


       reply	other threads:[~2015-03-23 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1427069076-26720-1-git-send-email-xerofoify@gmail.com>
2015-03-23 10:40 ` Dan Carpenter [this message]
     [not found]   ` <8FDBB6BF-55C6-44B5-A645-147F1BEAF388@gmail.com>
2015-03-23 13:06     ` [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket Dan Carpenter
     [not found]       ` <B6E63034-68D1-4728-B8C5-71BE94A1CFE3@gmail.com>
2015-03-24  7:08         ` Dan Carpenter
     [not found]           ` <15C5DCA5-565D-4E38-B247-4F18FF04930F@gmail.com>
2015-03-24 13:00             ` Dan Carpenter
2015-03-24 13:20               ` Joe Perches
2015-03-24 20:29             ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150323104006.GZ10964@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=br@ahlamon.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nitinkuppelur@gmail.com \
    --cc=pauldaviesc@gmail.com \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.