From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ya3P2-0005WB-Cf for kexec@lists.infradead.org; Mon, 23 Mar 2015 14:32:29 +0000 Date: Mon, 23 Mar 2015 10:31:58 -0400 From: Vivek Goyal Subject: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path Message-ID: <20150323143158.GB3172@redhat.com> References: <54F9D645.2050008@jp.fujitsu.com> <20150323034752.GD2068@dhcp-16-105.nay.redhat.com> <20150323071943.GA22765@gmail.com> <20150323133710.GA3172@redhat.com> <20150323135046.GA25012@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150323135046.GA25012@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Ingo Molnar Cc: Don Zickus , Baoquan He , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hidehiro.kawai.ez@hitachi.com, =?utf-8?B?IkhhdGF5YW1hLCBEYWlzdWtlL+eVkeWxsSDlpKfovJQi?= , mingo@redhat.com, ebiederm@xmission.com, masami.hiramatsu.pt@hitachi.com, akpm@linux-foundation.org, bp@suse.de T24gTW9uLCBNYXIgMjMsIDIwMTUgYXQgMDI6NTA6NDZQTSArMDEwMCwgSW5nbyBNb2xuYXIgd3Jv dGU6Cj4gCj4gKiBWaXZlayBHb3lhbCA8dmdveWFsQHJlZGhhdC5jb20+IHdyb3RlOgo+IAo+ID4g T24gTW9uLCBNYXIgMjMsIDIwMTUgYXQgMDg6MTk6NDNBTSArMDEwMCwgSW5nbyBNb2xuYXIgd3Jv dGU6Cj4gPiA+IAo+ID4gPiAqIEJhb3F1YW4gSGUgPGJoZUByZWRoYXQuY29tPiB3cm90ZToKPiA+ ID4gCj4gPiA+ID4gQ0MgbW9yZSBwZW9wbGUgLi4uCj4gPiA+ID4gCj4gPiA+ID4gT24gMDMvMDcv MTUgYXQgMDE6MzFhbSwgIkhhdGF5YW1hLCBEYWlzdWtlL+eVkeWxsSDlpKfovJQiIHdyb3RlOgo+ ID4gPiA+ID4gVGhlIGNvbW1pdCBmMDZlNTE1M2Y0YWUyZTJmM2IwMzAwZjBlMjYwZTQwY2I3ZmVm ZDQ1IGludHJvZHVjZWQKPiA+ID4gPiA+ICJjcmFzaF9rZXhlY19wb3N0X25vdGlmaWVycyIga2Vy bmVsIGJvb3Qgb3B0aW9uLCB3aGljaCB0b2dnbGVzCj4gPiA+ID4gPiB3aGVhdGhlciBwYW5pYygp IGNhbGxzIGNyYXNoX2tleGVjKCkgYmVmb3JlIHBhbmljX25vdGlmaWVycyBhbmQgZHVtcAo+ID4g PiA+ID4ga21zZyBvciBhZnRlci4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhlIHByb2JsZW0gaXMg dGhhdCB0aGUgY29tbWl0IG92ZXJsb29rcyBwYW5pY19vbl9vb3BzIGtlcm5lbCBib290Cj4gPiA+ ID4gPiBvcHRpb24uIElmIGl0IGlzIGVuYWJsZWQsIGNyYXNoX2tleGVjKCkgaXMgY2FsbGVkIGRp cmVjdGx5IHdpdGhvdXQKPiA+ID4gPiA+IGdvaW5nIHRocm91Z2ggcGFuaWMoKSBpbiBvb3BzIHBh dGguCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRvIGZpeCB0aGlzIGlzc3VlLCB0aGlzIHBhdGNoIGFk ZHMgYSBjaGVjayB0bwo+ID4gPiA+ID4gImNyYXNoX2tleGVjX3Bvc3Rfbm90aWZpZXJzIiBpbiB0 aGUgY29uZGl0aW9uIG9mIGtleGVjX3Nob3VsZF9jcmFzaCgpLgo+ID4gPiA+ID4gCj4gPiA+ID4g PiBBbHNvLCBwdXQgYSBjb21tZW50IGluIGtleGVjX3Nob3VsZF9jcmFzaCgpIHRvIGV4cGxhaW4g bm90IG9idmlvdXMKPiA+ID4gPiA+IHRoaW5ncyBvbiB0aGlzIHBhdGNoLgo+ID4gPiA+ID4gCj4g PiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBIQVRBWUFNQSBEYWlzdWtlIDxkLmhhdGF5YW1hQGpwLmZ1 aml0c3UuY29tPgo+ID4gPiA+ID4gQWNrZWQtYnk6IEJhb3F1YW4gSGUgPGJoZUByZWRoYXQuY29t Pgo+ID4gPiA+ID4gVGVzdGVkLWJ5OiBIaWRlaGlybyBLYXdhaSA8aGlkZWhpcm8ua2F3YWkuZXpA aGl0YWNoaS5jb20+Cj4gPiA+ID4gPiBSZXZpZXdlZC1ieTogTWFzYW1pIEhpcmFtYXRzdSA8bWFz YW1pLmhpcmFtYXRzdS5wdEBoaXRhY2hpLmNvbT4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIGlu Y2x1ZGUvbGludXgva2VybmVsLmggfCAgMyArKysKPiA+ID4gPiA+ICBrZXJuZWwva2V4ZWMuYyAg ICAgICAgIHwgMTEgKysrKysrKysrKysKPiA+ID4gPiA+ICBrZXJuZWwvcGFuaWMuYyAgICAgICAg IHwgIDIgKy0KPiA+ID4gPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IFRoaXMgaXMgaGFjayB1cG9uIGhhY2ssIGJ1dCB3aHkg d2FzIHRoaXMgY3JhcCBtZXJnZWQgaW4gdGhlIGZpcnN0IAo+ID4gPiBwbGFjZT8KPiA+ID4gCj4g PiA+IEkgc2VlIHR3byBwcm9ibGVtcyBqdXN0IGJ5IGN1cnNvcnkgcmV2aWV3Ogo+ID4gPiAKPiA+ ID4gMSkKPiA+ID4gCj4gPiA+IEZpcnN0bHksIHRoZSByZWFsIGJ1ZyBpbjoKPiA+ID4gCj4gPiA+ ICAgZjA2ZTUxNTNmNGFlICgia2VybmVsL3BhbmljLmM6IGFkZCAiY3Jhc2hfa2V4ZWNfcG9zdF9u b3RpZmllcnMiIG9wdGlvbiBmb3Iga2R1bXAgYWZ0ZXIgcGFuaWNfbm90aWZlcnMiKQo+ID4gPiAK PiA+ID4gV2FzIHRoYXQgY3Jhc2hfa2V4ZWMoKSB3YXMgY2FsbGVkIHVuY29uZGl0aW9uYWxseSBh ZnRlciBub3RpZmllcnMgd2VyZSAKPiA+ID4gY2FsbGVkLCB3aGljaCBzaG91bGQgYmUgZml4ZWQg dmlhIHRoZSBzaW1wbGUgcGF0Y2ggYmVsb3cgKHVudGVzdGVkKS4gCj4gPiA+IExvb2tzIG11Y2gg c2ltcGxlciB0aGFuIHlvdXIgZml4Lgo+ID4gPiAKPiA+IAo+ID4gSGkgSW5nbywKPiA+IAo+ID4g QWdyZWVkLiBZb3VyIHBhdGNoIGxvb2tzIGdvb2QuCj4gCj4gSW4gY2FzZSB5b3Ugd2FudCB0aGF0 IHNpbXBsZXIgZml4IGFuZCBuZWVkIG15IFNPQjoKPiAKPiAgIFNpZ25lZC1vZmYtYnk6IEluZ28g TW9sbmFyIDxtaW5nb0BrZXJuZWwub3JnPgo+IAo+IChidXQgSSBoYXZlIG5vdCB0ZXN0ZWQgaXQu KQoKSSB3aWxsIHF1aWNrbHkgdGVzdCBpdC4KClNvIHRoaXMgaXMgYSBnZW5lcmFsIGZpeCBidXQg bm90IGEgcmVwbGFjZW1lbnQgZm9yIGZpeCBpbiB0aGlzIHBhdGNoPwoKQmVjYXVzZSB0aGUgcHJv YmxlbSBvcmlnaW5hbCBwYXRjaCBpcyB0cnlpbmcgdG8gZml4IGlzIHRoYXQgY3Jhc2hfa2V4ZWMo KQpjYW4gYmUgY2FsbGVkIGZyb20gb3V0c2lkZSBwYW5pYygpIHRvbyAoa2V4ZWNfc2hvdWxkX2Ny YXNoKCkpIGFuZCBpbiB0aGF0CmNhc2UgcGFuaWMgbm90aWZpZXJzIHdpbGwgbm90IGJlIGNhbGxl ZC4gU28gdGhpcyBwYXRjaCBpcyBqdXN0IHRyeWluZyB0bwpkZWxheSB0aGUgY2FsbCB0byBjcmFz aF9rZXhlYygpIHRvIG1ha2UgaXQgcnVuIG11Y2ggbGF0ZXIuCgo+IAo+ID4gPiBTZWNvbmRseSwg YW5kIG1vcmUgaW1wb3J0YW50bHksIHRoZSB3aG9sZSBwcmVtaXNlIG9mIGNvbW1pdCAKPiA+ID4g ZjA2ZTUxNTNmNGFlIGlzIGJyb2tlbiBJTUhPOgo+ID4gPiAKPiA+ID4gICJUaGlzIGNhbiBoZWxw IHJhcmUgc2l0dWF0aW9ucyB3aGVyZSBrZHVtcCBmYWlscyBiZWNhdXNlIG9mIHVuc3RhYmxlCj4g PiA+ICAgY3Jhc2hlZCBrZXJuZWwgb3IgaGFyZHdhcmUgZmFpbHVyZSAobWVtb3J5IGNvcnJ1cHRp b24gb24gY3JpdGljYWwKPiA+ID4gICBkYXRhL2NvZGUpIgo+ID4gPiAKPiA+ID4gd3RmPwo+ID4g PiAKPiA+ID4gSWYgdGhlIGtlcm5lbCBjcmFzaGVkIGR1ZSB0byBhIGtlcm5lbCBjcmFzaCwgdGhl biB0aGUga2VybmVsIGJvb3RpbmcgCj4gPiA+IHVwIGluIHdoYXRldmVyIGhhcmR3YXJlIHN0YXRl IHNob3VsZCBiZSBhYmxlIHRvIGRvIGEgY2xlYW4gYm9vdHVwLiBUaGUgCj4gPiA+IGZpeCBmb3Ig dGhvc2UgJ3JhcmUgc2l0dWF0aW9ucycgc2hvdWxkIGJlIHRvIGZpeCB0aGUgcmVhbCBidWcgKGZv ciAKPiA+ID4gZXhhbXBsZSBieSBtYWtpbmcgaGFyZHdhcmUgZHJpdmVyIGluaXQgKG9yIGRlaW5p dCkgc2VxdWVuY2VzIG1vcmUgCj4gPiA+IHJvYnVzdCksIG5vdCB0byBwYXBlciBpdCBvdmVyIGJ5 IG9yZGVyaW5nIGFyb3VuZCBjcmFzaC10aW1lIHNlcXVlbmNlcyAKPiA+ID4gLi4uCj4gPiA+IAo+ ID4gPiBJZiBpdCBjcmFzaGVkIGR1ZSB0byBzb21lIGhhcmR3YXJlIGZhaWx1cmUsIHRoZXJlJ3Mg bGl0ZXJhbGx5IGFuIAo+ID4gPiBpbmZpbml0ZSBhbW91bnQgb2YgZmFpbHVyZSBtb2RlcyB0aGF0 IG1heSBvciBtYXkgbm90IGJlIGltcGFjdGVkIGJ5IAo+ID4gPiBrZXhlYyBjcmFzaC10aW1lIGhh bmRsaW5nIG9yZGVyaW5nLiBXZSBkb24ndCB3YW50IHRvIHB1dCBhIHppbGxpb24gCj4gPiA+IHN1 Y2ggZmxhZ3MgaW50byB0aGUga2VybmVsIHByb3BlciBqdXN0IHRvIGFsbG93IHRoZSBwZXJ0dXJi YXRpb24gb2YgCj4gPiA+IHRoZSBrZXJuZWwuCj4gPiAKPiA+IEkgdGhpbmsgb25lIG9mIHRoZSBt b3RpdmF0aW9ucyBiZWhpbmQgdGhpcyBwYXRjaCB3YXMgY2FsbCB0byBrbXNnX2R1bXAoKS4KPiA+ IFNvbWUgdmVuZG9ycyBoYXZlIGJlZW4gd2FudGluZyB0byBoYXZlIHRoZSBjYXBhYmlsaXR5IHRv IHNhdmUga2VybmVsIGxvZ3MKPiA+IHRvIHNvbWUgTlZSQU0gYmVmb3JlIHRyYW5zaXRpb24gdG8g c2Vjb25kIGtlcm5lbCBoYXBwZW5zLiBUaGVpciBhcmd1bWVudAo+ID4gaXMgdGhhdCBrZHVtcCBk b2VzIG5vdCBzdWNjZWVkIGFsbCB0aGUgdGltZSBhbmQgaWYga2R1bXAgZG9lcyBub3Qgc3VjY2Vl ZAo+ID4gdGhlbiBhdGxlYXN0IHRoZXkgaGF2ZSBzb21ldGhpbmcgdG8gd29yayB3aXRoIChrZXJu ZWwgbG9ncyByZXRyaWV2ZWQKPiA+IGZyb20gcHN0b3JlIGludGVyZmFjZSkuCj4gCj4gRG9lc24n dCBwc3RvcmUgYXR0YWNoIGl0c2VsZiB0byBwcmludGsgaXRzZWxmPyBBRkFJQ1MgaXQgZG9lczoK PiAKPiAgZnMvcHN0b3JlL3BsYXRmb3JtLmM6ICAgcmVnaXN0ZXJfY29uc29sZSgmcHN0b3JlX2Nv bnNvbGUpOwo+IAo+IHNvIHRoZSBwcmludGsgbG9nIGxlYWRpbmcgdXAgdG8gYW5kIGluY2x1ZGlu ZyB0aGUgY3Jhc2ggc2hvdWxkIGJlIAo+IGF2YWlsYWJsZSwgcmVnYXJkbGVzcyBvZiB0aGlzIHBh dGNoLiBXaGF0IGFtIEkgbWlzc2luZz8KClRoYXQncyBhIGdvb2QgcG9pbnQuIEkgd2FzIG5vdCBh d2FyZSBvZiBpdC4gSSBhbSBDY2luZyBEb24gWmlja3VzIGFzCmhlIGhhcyBzcGVudCBzb21lIHRp bWUgb24gdGhpcyBpbiB0aGUgcGFzdC4KCk1hc2FtaSwgd291bGQgeW91IGhhdmUgdGhvdWd0aHMg b24gdGhpcz8gSUlSQywgb25lIHJlYXNvbiB3aHkga21zZ19kdW1wKCkKd2FzIHdyaXR0ZW4gc28g dGhhdCBvbmUgY291bGQgZHVtcCBrZXJuZWwgbWVzc2FnZXMgdG8gYW4gTlZSQU0uIE9mIG9uZQpj b3VsZCBzaW1wbGUgcmVnaXN0ZXIgcHN0b3JlIGFzIGNvbnNvbGUsIHRoZW4gaG93IGttc2dfZHVt cCgpIHdpbGwKY29udGludWUgdG8gYmUgdXNlZnVsPwoKPiAKPiA+IE5vdCB0aGF0IEkgYWdyZWUg ZnVsbHkgd2l0aCB0aGlzIGFzIHByb2JsZW0gbWlnaHQgaGFwcGVuIHdoaWxlIHdlIAo+ID4gdHJ5 IHRvIHJ1biBwYW5pY19ub3RpZmllcnMgb3Iga21zZ19kdW1wIGhvb2tzIGFuZCBuZXZlciB0cmFu c2l0aW9uIAo+ID4gaW50byBrZHVtcCBrZXJuZWwuCj4gCj4gYnR3LiwgdGhpcyBpcyB0aGUgYmln IHByb2JsZW0gd2l0aCAnbm90aWZpZXJzJyBpbiBnZW5lcmFsOiB0aGV5IGFyZSAKPiBvcGFxdWUg d2l0aCBiYXJlbHkgYW55IHNlbWFudGljcyBkZWZpbmVkLCBhbmQgYSBzb3VyY2Ugb2YgY29uc3Rh bnQgCj4gY29uZnVzaW9uLgoKQWdyZWVkLiBUaGF0J3MgdGhlIHJlYXNvbiBFcmljIG5ldmVyIGxp a2VkIHRoZSBpZGVhIG9mIGxldHRpbmcgcGFuaWMKbm90aWZpZXJzIHJ1biBiZWZvcmUgY3Jhc2hf a2V4ZWMoKS4KCj4gCj4gPiBBbmQgaXQgaGFzIGJlZW4gbGl0ZXJhbGx5IHllYXJzIHNpbmNlIHNv bWUgZGV2ZWxvcGVycyBoYXZlIGJlZW4gCj4gPiBwdXNoaW5nIGZvciBhbGxvd2luZyB0byBydW4g cGFuaWMgbm90aWZpZXJzIGJlZm9yZSBjcmFzaF9rZXhlYygpLiAKPiA+IEVyaWMgQmllZGVybWFu IGhhcyBiZWVuIHB1c2hpbmcgYmFjayBzYXlpbmcgaXQgcmVkdWNlcyB0aGUgCj4gPiByZWxpYWJp bGl0eSBvZiBrZHVtcCBvcGVyYXRpb24gc28gdGhpcyBpcyBub3QgYWNjZXB0YWJsZS4KPiAKPiBT byB3aGF0IGRvIHRob3NlIG5vdGlmaWVycyBkbz8KCklJUkMsIHR3byBtYWluIHJlYXNvbnMgaGFk IGNvbWUgaW4gdGhlIHBhc3QuCgotIEluIGEgY2x1c3RlciBvZiBub2RlcywgcGVvcGxlIHdhbnRl ZCB0byBzZW5kIHNvbWUgc29ydCBvZiBub3RpZmljYXRpb25zCiAgdG8gbWFpbiBzZXJ2ZXIgdGhh dCBhIG5vZGUgaGFzIGNyYXNoZWQgYW5kIGRvbid0IGZlbmNlIGl0IG9mZiBhcyBpdAogIG1pZ2h0 IGJlIHNhdmluZyBkdW1wLgoKLSBBbmQgc2F2aW5nIGtlcm5lbCBsb2dzIHRvIG5vbiB2b2xhdGls ZSBzdG9yZS4KClRoZXJlIG1pZ2h0IGJlIG1vcmUgYW5kIEkgbWlnaHQgbm90IGJlIGF3YXJlIGFi b3V0IHRoZXNlLiBIYXRheWFtYSBhbmQKTWFzYW1pLCBjYW4geW91IHNoZWQgbW9yZSBsaWdodCBv biB0aGlzLgoKQlRXLCBmaXJzdCBwcm9ibGVtIHdlIGZhY2VkIGluIG91ciBjbHVzdGVycyB0b28g YW5kIG5vdyBpdCBoYXMgYmVlbiBmaXhlZC4KQmFzaWNhbGx5IHdlIHNlbmQgbm90aWZpY2F0aW9u cyBpbiBzZWNvbmQga2VybmVsIGluIHVzZXIgc3BhY2UgdG8gbWFzdGVyCnNlcnZlciB0aGF0IHRo aXMgbm9kZSBpcyBzdGlsbCBzYXZpbmcgZHVtcCBzbyBkb24ndCBmZW5jZSBpdCBvZmYuCgpUaGFu a3MKVml2ZWsKCj4gCj4gVGhhbmtzLAo+IAo+IAlJbmdvCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752574AbbCWOcd (ORCPT ); Mon, 23 Mar 2015 10:32:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53448 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbbCWOcc (ORCPT ); Mon, 23 Mar 2015 10:32:32 -0400 Date: Mon, 23 Mar 2015 10:31:58 -0400 From: Vivek Goyal To: Ingo Molnar Cc: Baoquan He , =?utf-8?B?IkhhdGF5YW1hLCBEYWlzdWtlL+eVkeWxsSDlpKfovJQi?= , ebiederm@xmission.com, masami.hiramatsu.pt@hitachi.com, hidehiro.kawai.ez@hitachi.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, akpm@linux-foundation.org, mingo@redhat.com, bp@suse.de, Don Zickus Subject: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path Message-ID: <20150323143158.GB3172@redhat.com> References: <54F9D645.2050008@jp.fujitsu.com> <20150323034752.GD2068@dhcp-16-105.nay.redhat.com> <20150323071943.GA22765@gmail.com> <20150323133710.GA3172@redhat.com> <20150323135046.GA25012@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150323135046.GA25012@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 02:50:46PM +0100, Ingo Molnar wrote: > > * Vivek Goyal wrote: > > > On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote: > > > > > > * Baoquan He wrote: > > > > > > > CC more people ... > > > > > > > > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > > > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > > > > > "crash_kexec_post_notifiers" kernel boot option, which toggles > > > > > wheather panic() calls crash_kexec() before panic_notifiers and dump > > > > > kmsg or after. > > > > > > > > > > The problem is that the commit overlooks panic_on_oops kernel boot > > > > > option. If it is enabled, crash_kexec() is called directly without > > > > > going through panic() in oops path. > > > > > > > > > > To fix this issue, this patch adds a check to > > > > > "crash_kexec_post_notifiers" in the condition of kexec_should_crash(). > > > > > > > > > > Also, put a comment in kexec_should_crash() to explain not obvious > > > > > things on this patch. > > > > > > > > > > Signed-off-by: HATAYAMA Daisuke > > > > > Acked-by: Baoquan He > > > > > Tested-by: Hidehiro Kawai > > > > > Reviewed-by: Masami Hiramatsu > > > > > --- > > > > > include/linux/kernel.h | 3 +++ > > > > > kernel/kexec.c | 11 +++++++++++ > > > > > kernel/panic.c | 2 +- > > > > > 3 files changed, 15 insertions(+), 1 deletion(-) > > > > > > This is hack upon hack, but why was this crap merged in the first > > > place? > > > > > > I see two problems just by cursory review: > > > > > > 1) > > > > > > Firstly, the real bug in: > > > > > > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option for kdump after panic_notifers") > > > > > > Was that crash_kexec() was called unconditionally after notifiers were > > > called, which should be fixed via the simple patch below (untested). > > > Looks much simpler than your fix. > > > > > > > Hi Ingo, > > > > Agreed. Your patch looks good. > > In case you want that simpler fix and need my SOB: > > Signed-off-by: Ingo Molnar > > (but I have not tested it.) I will quickly test it. So this is a general fix but not a replacement for fix in this patch? Because the problem original patch is trying to fix is that crash_kexec() can be called from outside panic() too (kexec_should_crash()) and in that case panic notifiers will not be called. So this patch is just trying to delay the call to crash_kexec() to make it run much later. > > > > Secondly, and more importantly, the whole premise of commit > > > f06e5153f4ae is broken IMHO: > > > > > > "This can help rare situations where kdump fails because of unstable > > > crashed kernel or hardware failure (memory corruption on critical > > > data/code)" > > > > > > wtf? > > > > > > If the kernel crashed due to a kernel crash, then the kernel booting > > > up in whatever hardware state should be able to do a clean bootup. The > > > fix for those 'rare situations' should be to fix the real bug (for > > > example by making hardware driver init (or deinit) sequences more > > > robust), not to paper it over by ordering around crash-time sequences > > > ... > > > > > > If it crashed due to some hardware failure, there's literally an > > > infinite amount of failure modes that may or may not be impacted by > > > kexec crash-time handling ordering. We don't want to put a zillion > > > such flags into the kernel proper just to allow the perturbation of > > > the kernel. > > > > I think one of the motivations behind this patch was call to kmsg_dump(). > > Some vendors have been wanting to have the capability to save kernel logs > > to some NVRAM before transition to second kernel happens. Their argument > > is that kdump does not succeed all the time and if kdump does not succeed > > then atleast they have something to work with (kernel logs retrieved > > from pstore interface). > > Doesn't pstore attach itself to printk itself? AFAICS it does: > > fs/pstore/platform.c: register_console(&pstore_console); > > so the printk log leading up to and including the crash should be > available, regardless of this patch. What am I missing? That's a good point. I was not aware of it. I am Ccing Don Zickus as he has spent some time on this in the past. Masami, would you have thougths on this? IIRC, one reason why kmsg_dump() was written so that one could dump kernel messages to an NVRAM. Of one could simple register pstore as console, then how kmsg_dump() will continue to be useful? > > > Not that I agree fully with this as problem might happen while we > > try to run panic_notifiers or kmsg_dump hooks and never transition > > into kdump kernel. > > btw., this is the big problem with 'notifiers' in general: they are > opaque with barely any semantics defined, and a source of constant > confusion. Agreed. That's the reason Eric never liked the idea of letting panic notifiers run before crash_kexec(). > > > And it has been literally years since some developers have been > > pushing for allowing to run panic notifiers before crash_kexec(). > > Eric Biederman has been pushing back saying it reduces the > > reliability of kdump operation so this is not acceptable. > > So what do those notifiers do? IIRC, two main reasons had come in the past. - In a cluster of nodes, people wanted to send some sort of notifications to main server that a node has crashed and don't fence it off as it might be saving dump. - And saving kernel logs to non volatile store. There might be more and I might not be aware about these. Hatayama and Masami, can you shed more light on this. BTW, first problem we faced in our clusters too and now it has been fixed. Basically we send notifications in second kernel in user space to master server that this node is still saving dump so don't fence it off. Thanks Vivek > > Thanks, > > Ingo