From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752613AbbCWRQ3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 13:16:29 -0400
Received: from mail.skyhub.de ([78.46.96.112]:55385 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752120AbbCWRQ1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 13:16:27 -0400
Date: Mon, 23 Mar 2015 18:14:44 +0100
From: Borislav Petkov <bp@alien8.de>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: stop using PER_CPU_VAR(kernel_stack)
Message-ID: <20150323171443.GA3880@pd.tnic>
References: <1426970678-600-1-git-send-email-dvlasenk@redhat.com>
 <20150323101815.35bd61c7@gandalf.local.home>
 <551048E9.6060800@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <551048E9.6060800@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 23, 2015 at 06:10:01PM +0100, Denys Vlasenko wrote:
> We want to get rid of kernel_stack, since it is redundant:
> in 64-bits, PER_CPU_VAR(cpu_tss + TSS_sp0) can be used instead,
> in 32-bits, PER_CPU_VAR(cpu_current_top_of_stack) can be used instead.

We probably should have a macro unifying those on both bitness.
Especially 64-bit is really non-telling - I can't really deduce from
"cpu_tss + TSS_sp0" that it is the kernel stack ptr.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--