All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Marianne Moeller Knudsen <marianne@masu.dk>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: sm750fb: Move misplaced open brace to previous line
Date: Mon, 23 Mar 2015 22:29:35 +0100	[thread overview]
Message-ID: <20150323212935.GA26156@kroah.com> (raw)
In-Reply-To: <20150320182043.GA2677@debianvm>

On Fri, Mar 20, 2015 at 07:20:43PM +0100, Marianne Moeller Knudsen wrote:
> Move open brace { to same line as statement. Issue found by checkpatch.
> 
> Signed-off-by: Marianne Moeller Knudsen <marianne@masu.dk>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 33add64..0392020 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -118,8 +118,7 @@ void setChipClock(unsigned int frequency)
>  			return;
>  #endif
>  
> -    if (frequency != 0)
> -    {
> +    if (frequency != 0) {
>          /*
>           * Set up PLL, a structure to hold the value to be set in clocks.
>           */

This doesn't apply to my tree, and neither did any of the other patches
you sent me for this driver :(

Please sync up on the proper git tree and resend _ALL_ of your patches,
in a patch series, so that I have a chance to be able to apply them.

thanks,

greg k-h


      reply	other threads:[~2015-03-23 23:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 18:20 [PATCH] staging: sm750fb: Move misplaced open brace to previous line Marianne Moeller Knudsen
2015-03-23 21:29 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150323212935.GA26156@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=marianne@masu.dk \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.