From: Greg KH <gregkh@linuxfoundation.org>
To: Vatika Harlalka <vatikaharlalka@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 08/10] Staging: rtl8712: Fix incorrect assignment type in rtl8712_xmit.c
Date: Mon, 23 Mar 2015 22:37:23 +0100 [thread overview]
Message-ID: <20150323213723.GA935@kroah.com> (raw)
In-Reply-To: <68911b4fb09acb91c39291e2596ce73cc3e8e2f2.1426983594.git.vatikaharlalka@gmail.com>
On Sun, Mar 22, 2015 at 06:22:27AM +0530, Vatika Harlalka wrote:
> This patch is to fix Sparse warnings due to incorrect assignment
> type in rtl8712_xmit.c
>
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_xmit.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 732e774..c0c86ef 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -550,22 +550,22 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
> * This will maybe make the handshake smooth.
> */
> /*driver uses data rate*/
> - ptxdesc->txdw4 = cpu_to_le32(0x80000000);
> - ptxdesc->txdw5 = cpu_to_le32(0x001f8000);/*1M*/
> + ptxdesc->txdw4 = 0x80000000;
> + ptxdesc->txdw5 = 0x001f8000;/*1M*/
Eeek, this just broke the driver!
next prev parent reply other threads:[~2015-03-23 23:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 0:49 [PATCH 01/10] Staging: rtl8712: Fix incorrect assignment type in ieee80211.c Vatika Harlalka
2015-03-22 0:49 ` [PATCH 02/10] Staging: rtl8712: Fix invalid assignment '|=' " Vatika Harlalka
2015-03-22 0:50 ` [PATCH 04/10] Staging: rtl8712: Fix incorrect assignment type in rtl871x_cmd.c Vatika Harlalka
2015-03-22 0:51 ` [PATCH 05/10] Staging: rtl8712: Fix cast to restricted __le16 in hal_init.c Vatika Harlalka
2015-03-22 0:51 ` [PATCH 06/10] Staging: rtl8712: Fix invalid assignment '|=' " Vatika Harlalka
2015-03-22 0:52 ` [PATCH 07/10] Staging: rtl8712: Fix invalid assignment '|=' in rtl8712_xmit.c Vatika Harlalka
2015-03-22 0:52 ` [PATCH 08/10] Staging: rtl8712: Fix incorrect assignment type " Vatika Harlalka
2015-03-23 6:49 ` [Outreachy kernel] " Julia Lawall
2015-03-23 11:19 ` Vatika Harlalka
2015-03-23 13:49 ` Julia Lawall
2015-03-23 22:20 ` Vatika Harlalka
2015-03-23 21:37 ` Greg KH [this message]
2015-03-22 0:52 ` [PATCH 09/10] Staging: rtl8712: Fix cast to restricted __le32 in rtl871x_mlme.c Vatika Harlalka
2015-03-22 0:52 ` [PATCH 10/10] Staging: rtl8712: Fix incorrect assignment type " Vatika Harlalka
2015-03-22 7:06 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323213723.GA935@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=vatikaharlalka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.