From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 24 Mar 2015 10:40:03 +0000 Subject: Re: [PATCH 1/2] staging: sm7xxfb: start using module parameters Message-Id: <20150324104003.GA28721@kroah.com> List-Id: References: <1427172609-4318-1-git-send-email-sudipm.mukherjee@gmail.com> <20150324094826.GB6378@kroah.com> <20150324102835.GA7986@sudip-PC> In-Reply-To: <20150324102835.GA7986@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sudip Mukherjee Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 03:58:35PM +0530, Sudip Mukherjee wrote: > On Tue, Mar 24, 2015 at 10:48:26AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Mar 24, 2015 at 10:20:08AM +0530, Sudip Mukherjee wrote: > > > + "\t\t0x31B = 1280x1024-24\n" > > > + "\t\tUsual example:\n" > > > + "\t\tinsmod ./sm7xxfb.ko mode_option=\"0x301\"\n"); > > > + > > > > That's funny :) > > > > And how do you handle multiple devices in the system? > frankly speaking, never got the idea about multiple devices. > > > > > :( > > > > Seriously, never use module parameters for device parameters, they are > > two different things. The framebuffer core has options for handling > > modes, why not use them? > > > > And yes, lots of framebuffer drivers do have crazy module parameters, > > but that doesn't mean you have to perpetuate the insanity, please do > > things properly here. > i am learning from other framebuffer drivers. i guess i should only > see at skeletonfb.c and not the others. > please drop this 1/2 patch, do i need to resend the 2/2 which adds > the MODULE_DEVICE_TABLE ? Please do, it's long gone from my queue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbbCXKkp (ORCPT ); Tue, 24 Mar 2015 06:40:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54051 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752445AbbCXKkn (ORCPT ); Tue, 24 Mar 2015 06:40:43 -0400 Date: Tue, 24 Mar 2015 11:40:03 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: sm7xxfb: start using module parameters Message-ID: <20150324104003.GA28721@kroah.com> References: <1427172609-4318-1-git-send-email-sudipm.mukherjee@gmail.com> <20150324094826.GB6378@kroah.com> <20150324102835.GA7986@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150324102835.GA7986@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 03:58:35PM +0530, Sudip Mukherjee wrote: > On Tue, Mar 24, 2015 at 10:48:26AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Mar 24, 2015 at 10:20:08AM +0530, Sudip Mukherjee wrote: > > > + "\t\t0x31B = 1280x1024-24\n" > > > + "\t\tUsual example:\n" > > > + "\t\tinsmod ./sm7xxfb.ko mode_option=\"0x301\"\n"); > > > + > > > > That's funny :) > > > > And how do you handle multiple devices in the system? > frankly speaking, never got the idea about multiple devices. > > > > > :( > > > > Seriously, never use module parameters for device parameters, they are > > two different things. The framebuffer core has options for handling > > modes, why not use them? > > > > And yes, lots of framebuffer drivers do have crazy module parameters, > > but that doesn't mean you have to perpetuate the insanity, please do > > things properly here. > i am learning from other framebuffer drivers. i guess i should only > see at skeletonfb.c and not the others. > please drop this 1/2 patch, do i need to resend the 2/2 which adds > the MODULE_DEVICE_TABLE ? Please do, it's long gone from my queue.