From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 1/5] tools/mkrpm: improve version.release handling Date: Tue, 24 Mar 2015 13:15:47 +0100 Message-ID: <20150324121547.GA17175@aepfle.de> References: <1426872279-5001-1-git-send-email-olaf@aepfle.de> <1426872279-5001-2-git-send-email-olaf@aepfle.de> <55103C3E.3000302@eu.citrix.com> <20150323175232.GA13774@aepfle.de> <20150323184941.GA13561@aepfle.de> <551062D4.1040203@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <551062D4.1040203@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Ian Jackson , "xen-devel@lists.xen.org" , Wei Liu , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, Mar 23, George Dunlap wrote: > On 03/23/2015 06:49 PM, Olaf Hering wrote: > > release will be anything after a dash, or 0. And an optional ".$PKG_RELEASE" > > will be appended. > Just trying to decode this: So if I were using PKG_RELEASE=$(date ...), > then I'd get something like > > xen-4.6-unstable.20150323160547.x86_64.rpm > xen-4.4.2-0.20150323160547.x86_64.rpm > > For non-release states and release states, respectively; and if I hadn't > set PKG_RELEASE, those would come out like this: > > xen-4.6-unstable.x86_64.rpm > xen-4.4.2-0.x86_64.rpm > > Is that about right? That all looks good to me. Ok, so I will send an updated patch. Olaf