From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbbCXMhK (ORCPT ); Tue, 24 Mar 2015 08:37:10 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33589 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbbCXMhH (ORCPT ); Tue, 24 Mar 2015 08:37:07 -0400 Date: Tue, 24 Mar 2015 18:06:56 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: Benjamin Romer , David Kershner , Greg Kroah-Hartman , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] staging: unisys: remove unneeded comparison Message-ID: <20150324123656.GA11812@sudip-PC> References: <1427199457-11771-1-git-send-email-sudipm.mukherjee@gmail.com> <20150324123021.GS10964@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150324123021.GS10964@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 03:30:21PM +0300, Dan Carpenter wrote: > On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote: > > visorchipset_file_cleanup() is called from visorchipset_exit() which > > is the module_exit function and this function is executing means > > module_init succeeded, so registered will always be true at this time. > > and majordev has also been initialized in the init function. hence > > these comparisons will always be true. > > > > Signed-off-by: Sudip Mukherjee > > This is a partial patch. The "one thing per patch" means don't do half > a thing per patch. > > We now set "registered" but there are no users. it is being removed separately in the 4/4 patch. do you want that to be combined here in this patch? but then won't that become 2 different changes in a single patch? my message says we are removing that as the comparison is always true. regards sudip > > regards, > dan carpenter >