From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/3] drm/panel: Add display_timing support Date: Tue, 24 Mar 2015 13:40:59 +0100 Message-ID: <20150324124058.GA23455@ulmo.nvidia.com> References: <1418319166-23357-1-git-send-email-p.zabel@pengutronix.de> <20150203133015.GH15068@ulmo.nvidia.com> <1424700272.3623.7.camel@pengutronix.de> <1425383383.3146.53.camel@pengutronix.de> <20150324113430.GN18115@ulmo.nvidia.com> <1427197964.3180.20.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1802996303==" Return-path: Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 163016E68A for ; Tue, 24 Mar 2015 05:41:04 -0700 (PDT) Received: by pdbni2 with SMTP id ni2so220387215pdb.1 for ; Tue, 24 Mar 2015 05:41:03 -0700 (PDT) In-Reply-To: <1427197964.3180.20.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: Steffen Trumtrar , dri-devel@lists.freedesktop.org, kernel@pengutronix.de List-Id: dri-devel@lists.freedesktop.org --===============1802996303== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 24, 2015 at 12:52:44PM +0100, Philipp Zabel wrote: > Am Dienstag, den 24.03.2015, 12:34 +0100 schrieb Thierry Reding: > [...] > > > > Would you prefer > > > > struct display_timing *(*get_timing)(struct drm_panel *panel); > > > > ? > > >=20 > > > I'd like to resend this. Please let me know if you want me to change > > > this function prototype. > >=20 > > I have no objections to keeping the current prototype. It's something we > > can always fixup if we want to. Also keeping the symmetry with min/max > > values for hactive and vactive is okay in my opinion. > >=20 > > Were there any other remaining points? If not I'll just apply this as > > is. >=20 > No, I'm happy if you apply this as is. Done. I touched up a couple of things in the commit messages and made a minor change to the loop which copies the timings in the simple-panel driver (extract the min(num_timings, p->desc->num_timings) out of the for statement). Nothing major, but it might still be good if you could test, just to make sure I didn't make a mess. This should be in tomorrow's linux-next, but if you want to take a peek before that, you can grab it from here: git://anongit.freedesktop.org/tegra/linux.git#drm/panel/for-next Thierry --VS++wcV0S1rZb1Fb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVEVtZAAoJEN0jrNd/PrOhY/gQALEyIT9UpUtf5vCdymMw1K4/ NQmtkmKLiMZM06miimwu8rK6hwt4Y/Zy7nOAe1+IXkmBKbkUzo91yeFjJnRjBPDu T3Z/VcamqH/kVNFnHNexryIWxOaKmKDrfKLyNYgci46d5BOyvr+gp9vfLntS6eMi N8YudbofMzzBOXCxDEJ8fhy+LgubbRjj+fZ3Mo9icnz00kALVN5+sCp8nvZiBrO0 IkNMSBYwJWQTH8sghHxHsrhiXZFtEiWbsIq3zzsmuEIkMviril2SwGp7WFEB9jiD +yad/EjksI9I/TXO0auUMTzys+LTJCmOlHCgMBucL/gibFUy1yRv48BwckcKKJXg Iq6oPlAWTgn8kzPmPt7/BOo+baIWEuzIuQakqfh5kE/zZoC/iaegE6xfeEQIA34+ 7ZglyVVvWjs8dnKHM/buquqc1aK/GlTkscOrZEa8ivdjOMGA+djNb8/GHuECO2ig 4T2GQVI5P9sQvA3bdlWkjwumHClJSlgZrVX7DLursvf9xVKsnuqDcR6TSDZ5fV32 J16wNg+BIdufWVghxb/lBQbMi1H0T7YDdpxpEoD/TUVXSlFtLS2cz9rvOxdE68nR oibQx3h4sHhMlT4hNvzhi8rEQO4fQoehoKXhYArUv2wNGvkZYEScxDpcSHw28nbd SQjyfB1/kcOLxhq/Ll2L =dGny -----END PGP SIGNATURE----- --VS++wcV0S1rZb1Fb-- --===============1802996303== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1802996303==--