From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbbCXNOs (ORCPT ); Tue, 24 Mar 2015 09:14:48 -0400 Received: from casper.infradead.org ([85.118.1.10]:35350 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbbCXNOr (ORCPT ); Tue, 24 Mar 2015 09:14:47 -0400 Date: Tue, 24 Mar 2015 14:14:39 +0100 From: Peter Zijlstra To: Morten Rasmussen Cc: mingo@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, yuyang.du@intel.com, preeti@linux.vnet.ibm.com, mturquette@linaro.org, nico@linaro.org, rjw@rjwysocki.net, juri.lelli@arm.com, linux-kernel@vger.kernel.org Subject: Re: [RFCv3 PATCH 36/48] sched: Count number of shallower idle-states in struct sched_group_energy Message-ID: <20150324131439.GO23123@twins.programming.kicks-ass.net> References: <1423074685-6336-1-git-send-email-morten.rasmussen@arm.com> <1423074685-6336-37-git-send-email-morten.rasmussen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423074685-6336-37-git-send-email-morten.rasmussen@arm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 04, 2015 at 06:31:13PM +0000, Morten Rasmussen wrote: > cpuidle associates all idle-states with each cpu while the energy model > associates them with the sched_group covering the cpus coordinating > entry to the idle-state. To get idle-state power consumption it is > therefore necessary to translate from cpuidle idle-state index to energy > model index. For this purpose it is helpful to know how many idle-states > that are listed in lower level sched_groups (in struct > sched_group_energy). I think this could use some text to describe how that number is useful. I suspect is has something to do with bigger domains having more idle modes (package C states etc..).