From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754238AbbCXQFt (ORCPT ); Tue, 24 Mar 2015 12:05:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59108 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753346AbbCXQFm (ORCPT ); Tue, 24 Mar 2015 12:05:42 -0400 Date: Tue, 24 Mar 2015 09:06:09 -0700 From: Mark Brown To: Charles Keepax Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Message-ID: <20150324160609.GD17265@sirena.org.uk> References: <1427207276-28038-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/3yNEOqWowh/8j+e" Content-Disposition: inline In-Reply-To: <1427207276-28038-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Cookie: A good memory does not equal pale ink. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 12.104.145.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/3yNEOqWowh/8j+e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 24, 2015 at 02:27:56PM +0000, Charles Keepax wrote: > +static int arizona_ldo1_hc_set_voltage_time_sel(struct regulator_dev *rdev, > + unsigned int old_selector, > + unsigned int new_selector) > +{ > + /* if moving to 1.8v allow time for it to reach voltage */ > + if (new_selector == rdev->desc->n_voltages - 1) > + return 25; > + else > + return 0; > +} So changes to move to the top voltage always take constant time while all other voltage changes are instantaneous? That doesn't seem right. I'd expect something more like a calculation based on some number of miliseconds per milivolt. --/3yNEOqWowh/8j+e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVEYtxAAoJECTWi3JdVIfQ9+4H/iq6gOBrbaHRWZFtqo5REm/v C9hc/+mhqe8643i1z3VcbFO4K2jVxbGy9VbAraKSTIlqlOvcVfFPypWrme4+y0kl Erw025Ip1y9+q4PWD2sl6GGRLG4kMZijQYjxWaKId/1i6VaY3ZPBSp7o9kpRWa3d 1D97hwlmZZ48+NoAAJ7Wb4UC8gDZLPezRNyEy/cAQG6p1Ww98gRJ6R2Z6oboZa1o oxJUpB4jOEXh9gQVSrrNpsVCtOT5HgcDaGqIVPbyTsJ63VuSOtw3WqqjFs7rOMaB 2sJjbWEPnWkbxT9WIStYlJ4LNCGOQtEkc1m4Mgf2UKHCcpimehBwr3b8gyPm56Y= =XOVV -----END PGP SIGNATURE----- --/3yNEOqWowh/8j+e--