From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932348AbbCXQIi (ORCPT ); Tue, 24 Mar 2015 12:08:38 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59125 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932197AbbCXQIe (ORCPT ); Tue, 24 Mar 2015 12:08:34 -0400 Date: Tue, 24 Mar 2015 09:08:57 -0700 From: Mark Brown To: Markus Pargmann Cc: Liam Girdwood , Wolfram Sang , kernel@pengutronix.de, linux-kernel@vger.kernel.org Message-ID: <20150324160857.GF17265@sirena.org.uk> References: <1427198883-6577-1-git-send-email-mpa@pengutronix.de> <1427198883-6577-2-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xaMk4Io5JJdpkLEb" Content-Disposition: inline In-Reply-To: <1427198883-6577-2-git-send-email-mpa@pengutronix.de> X-Cookie: A good memory does not equal pale ink. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 12.104.145.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] regulator: max8660: Add error message for missing regulator data X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xaMk4Io5JJdpkLEb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 24, 2015 at 01:08:03PM +0100, Markus Pargmann wrote: > The driver probe fails when there is a subdevice without platform_data. > Add a error message so it is clear what failed. ... > for (i = 0; i < pdata->num_subdevs; i++) { > - if (!pdata->subdevs[i].platform_data) > + if (!pdata->subdevs[i].platform_data) { > + dev_err(dev, "No data for %d regulator\n", i); > return -EINVAL; > + } Why is the platform data mandatory? In general the goal is that a regulator driver should be able to probe with no platform data. --xaMk4Io5JJdpkLEb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVEYwYAAoJECTWi3JdVIfQSg0H/i2uQsYtwsJkSh5o9996CYHG Ad2X0tyWFYggix4nUHSR4k44tPAN3p7G4Fviinuap7xfOWL7zD7oiT6X/TiOUb+I 4/gYFi3SvI5MVERzK9bzCM61tD6MVNybFgmFqbpBWNSUp71RuFr8SPaZoxF9y4Bb Iz3WcRrKdvUQrwLkCBczyZyQtgEX8PXcJluzrLkNWAnBT4U5VTQBusbqWFcBFjf0 X3wOJk10w8OSTe41U+1d+rr0QFfC7Cvau7uYY0yDXwobtB16m/rFBOdgvckbQAIU 64k6Cp2UyPekWETatF7MyKmKTXRYfz2UfEOLQ0pVblTOo1LF/FeVFVb0nQfiz80= =G+LU -----END PGP SIGNATURE----- --xaMk4Io5JJdpkLEb--