Re: [PATCH 1/2] regulator: max8660: Remove boot_on handling

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On Tue, Mar 24, 2015 at 01:08:02PM +0100, Markus Pargmann wrote:

> boot_on is handled by the regulator core. It will call enable() on the
> regulators that are specified to be boot_on. So we don't require any
> additional handling in this driver

>  		switch (pdata->subdevs[i].id) {
>  		case MAX8660_V3:
> -			if (boot_on)
> -				max8660->shadow_regs[MAX8660_OVER1] |= 1;
> -			break;
> -

So, this is updating the register default value rather than writing to
the device.  That suggests that the purpose is to either avoid needless
write outs to the device or something, or at the very least it's not a
completely direct reimplementation of the core functionality.  It is
certainly underdocumented at the minute (and the driver probably wants
to be converted to regmap) but this makes me a bit cautious about
obvious cleanups missing something.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]