From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344AbbCXQkS (ORCPT ); Tue, 24 Mar 2015 12:40:18 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:44263 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932080AbbCXQkO (ORCPT ); Tue, 24 Mar 2015 12:40:14 -0400 Date: Tue, 24 Mar 2015 17:40:11 +0100 From: Markus Pargmann To: Mark Brown Cc: Liam Girdwood , Wolfram Sang , kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] regulator: max8660: Add error message for missing regulator data Message-ID: <20150324164011.GL28604@pengutronix.de> References: <1427198883-6577-1-git-send-email-mpa@pengutronix.de> <1427198883-6577-2-git-send-email-mpa@pengutronix.de> <20150324160857.GF17265@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hdW7zL/qDS6RXdAL" Content-Disposition: inline In-Reply-To: <20150324160857.GF17265@sirena.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:36:40 up 62 days, 6:43, 163 users, load average: 3.41, 3.03, 2.11 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hdW7zL/qDS6RXdAL Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 24, 2015 at 09:08:57AM -0700, Mark Brown wrote: > On Tue, Mar 24, 2015 at 01:08:03PM +0100, Markus Pargmann wrote: > > The driver probe fails when there is a subdevice without platform_data. > > Add a error message so it is clear what failed. >=20 > ... >=20 > > for (i =3D 0; i < pdata->num_subdevs; i++) { > > - if (!pdata->subdevs[i].platform_data) > > + if (!pdata->subdevs[i].platform_data) { > > + dev_err(dev, "No data for %d regulator\n", i); > > return -EINVAL; > > + } >=20 > Why is the platform data mandatory? In general the goal is that a > regulator driver should be able to probe with no platform data. subdevs[]->platform_data is a struct regulator_init_data which has to exist so we can register the regulator later. Best Regards, Markus --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --hdW7zL/qDS6RXdAL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEZNqAAoJEEpcgKtcEGQQgqoP/0NuiOKGx+bwEz9ULDD24A7V Q1SDJwky52+4aT7o3ERm8y4+310QS1zv3zd7v6jQHwU/I5T6UbU8O7rAxg1yQdL1 /eNkC7kGhhRgMA0deqkExlHcNQPy5c9MxqmCB9H21SA3xtk73BiwRAoSstDe/axh 2iKJO7fFhjzSC1V1dVB51Cnnbo5SQKvFht8o7q82mQq7QhiFRRKdnlLsr8rQuj3K 6OroYG4kdoRBjvf7Ae2ye9PqLcSW1BwSETNzigdJGgOE+quVVOeBC4A6/QsHvAqy vlnHvX3PrqBFg29S7O58n/XbWnoZN7TAKnt3bnu/qUakCtuOMVYIhNE3nw5L9gU/ 7XuH3oDtj9BLMPZUNapk+HKkyvnBwdDQh//1Wy5c2+J+ycveFgwFOWweOMU0Q1a+ An039Yb58RGCECm0yRkrVaNbI2Nij2kDczdY65M9RGnxjIEySgioL6cfVqYnct/+ XLUxkqUXOOBimapqoY5AMiLLveF3ZhVyfOJq+B8QVfJ/kqjKrK7P/owOTXtcmtTj BY28gEGUZzaoqGpvW3pQys6jD72psiRm0kShxcP6biqTF0Erf2wax23T0ToVHzL0 FMwudwQ+d55vyzcnRewK3g9IDR9B/A8Rf9vGYuVKuC6kpOuBToF0FFqGe6iONbO/ caErQG5eFT6PvQkB3IKJ =XDf0 -----END PGP SIGNATURE----- --hdW7zL/qDS6RXdAL--