From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Date: Tue, 24 Mar 2015 19:15:20 +0100 Message-ID: <20150324181520.GE1321@linutronix.de> References: <20150317163541.080310081@goodmis.org> <20150317163617.218582800@goodmis.org> <20150317163551.3093b6c2@gandalf.local.home> <1426753029.4168.80.camel@gmail.com> <20150319122611.0d002d48@gandalf.local.home> <550AFC6A.4050901@hp.com> <1426960943.4677.34.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Thavatchai Makphaibulchoke , Steven Rostedt , linux-kernel@vger.kernel.org, linux-rt-users , Thomas Gleixner , Carsten Emde , John Kacur , Paul Gortmaker To: Mike Galbraith Return-path: Received: from www.linutronix.de ([62.245.132.108]:48408 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbCXSPZ convert rfc822-to-8bit (ORCPT ); Tue, 24 Mar 2015 14:15:25 -0400 Content-Disposition: inline In-Reply-To: <1426960943.4677.34.camel@gmail.com> Sender: linux-rt-users-owner@vger.kernel.org List-ID: * Mike Galbraith | 2015-03-21 19:02:23 [+0100]: >> Steve, I'm still working on the fix we discussed using dummy irq_tas= k. >> I should be able to submit some time next week, if still interested. >>=20 >> Either that, or I think we should remove the function >> spin_do_trylock_in_interrupt() to prevent any possibility of running >> into similar problems in the future. > >Why can't we just Let swapper be the owner when in irq with no dummy? so you abuse the owner to be swapper and mask it out everywhere. It doe= s not look like a final solution. I'm more inclined to take you other patch. In the end I hope we get a timer re-work and do not need any hackary around it=E2=80=A6 >I have "don't raise timer unconditionally" re-applied, the check for a >running callback bits of my nohz_full fixlet, and the below on top of >that, and all _seems_ well. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-rt-user= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479AbbCXSP3 (ORCPT ); Tue, 24 Mar 2015 14:15:29 -0400 Received: from www.linutronix.de ([62.245.132.108]:48408 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbCXSPZ convert rfc822-to-8bit (ORCPT ); Tue, 24 Mar 2015 14:15:25 -0400 Date: Tue, 24 Mar 2015 19:15:20 +0100 From: Sebastian Andrzej Siewior To: Mike Galbraith Cc: Thavatchai Makphaibulchoke , Steven Rostedt , linux-kernel@vger.kernel.org, linux-rt-users , Thomas Gleixner , Carsten Emde , John Kacur , Paul Gortmaker Subject: Re: [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Message-ID: <20150324181520.GE1321@linutronix.de> References: <20150317163541.080310081@goodmis.org> <20150317163617.218582800@goodmis.org> <20150317163551.3093b6c2@gandalf.local.home> <1426753029.4168.80.camel@gmail.com> <20150319122611.0d002d48@gandalf.local.home> <550AFC6A.4050901@hp.com> <1426960943.4677.34.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1426960943.4677.34.camel@gmail.com> X-Key-Id: 2A8CF5D1 X-Key-Fingerprint: 6425 4695 FFF0 AA44 66CC 19E6 7B96 E816 2A8C F5D1 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mike Galbraith | 2015-03-21 19:02:23 [+0100]: >> Steve, I'm still working on the fix we discussed using dummy irq_task. >> I should be able to submit some time next week, if still interested. >> >> Either that, or I think we should remove the function >> spin_do_trylock_in_interrupt() to prevent any possibility of running >> into similar problems in the future. > >Why can't we just Let swapper be the owner when in irq with no dummy? so you abuse the owner to be swapper and mask it out everywhere. It does not look like a final solution. I'm more inclined to take you other patch. In the end I hope we get a timer re-work and do not need any hackary around it… >I have "don't raise timer unconditionally" re-applied, the check for a >running callback bits of my nohz_full fixlet, and the below on top of >that, and all _seems_ well. Sebastian