From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YafYT-0007jM-Ej for qemu-devel@nongnu.org; Wed, 25 Mar 2015 03:16:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YafYQ-0003UL-7X for qemu-devel@nongnu.org; Wed, 25 Mar 2015 03:16:45 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:15608 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YafYP-0003U7-W2 for qemu-devel@nongnu.org; Wed, 25 Mar 2015 03:16:42 -0400 Date: Wed, 25 Mar 2015 08:16:23 +0100 From: Alberto Garcia Message-ID: <20150325071623.GA19368@igalia.com> References: <1427251352-14809-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427251352-14809-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] block: Switch to host monotonic clock for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , pbonzini@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi On Wed, Mar 25, 2015 at 10:42:32AM +0800, Fam Zheng wrote: > Block jobs are confusingly inconsistent between with and without > throttling: if user sets a bps limit, starts a block job, then stops > vm, the block job will not make any progress; in contrary, if user > unsets the bps limit, the block job will run normally. Wait, that's not what happens: a) If you start a job then stop the vm then the job will be completed immediately. b) If you stop the vm then start the job then it won't make any progress. This patch fixes b), but a) still happens. Berto