From: Ingo Molnar <mingo@kernel.org>
To: carlossilveirajr@gmail.com
Cc: mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix braces to GNU style
Date: Wed, 25 Mar 2015 09:58:40 +0100 [thread overview]
Message-ID: <20150325085840.GA32673@gmail.com> (raw)
In-Reply-To: <1427248767-5141-1-git-send-email-carlossilveirajr@gmail.com>
* carlossilveirajr@gmail.com <carlossilveirajr@gmail.com> wrote:
> From: Carlos Roberto Silveira Junior <carlossilveirajr@gmail.com>
>
> ---
> kernel/sched/fair.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 7ce18f3..834aa55 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -296,13 +296,12 @@ static inline void list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> * reduces this to two cases.
> */
> if (cfs_rq->tg->parent &&
> - cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list) {
> + cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list)
> list_add_rcu(&cfs_rq->leaf_cfs_rq_list,
> &rq_of(cfs_rq)->leaf_cfs_rq_list);
> - } else {
> + else
> list_add_tail_rcu(&cfs_rq->leaf_cfs_rq_list,
> &rq_of(cfs_rq)->leaf_cfs_rq_list);
> - }
>
> cfs_rq->on_list = 1;
> /* We should have no load, but we need to update last_decay. */
> @@ -505,9 +504,9 @@ static void __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
> * We dont care about collisions. Nodes with
> * the same key stay together.
> */
> - if (entity_before(se, entry)) {
> + if (entity_before(se, entry))
> link = &parent->rb_left;
> - } else {
> + else {
> link = &parent->rb_right;
> leftmost = 0;
> }
But in the kernel we are following the Linux kernel style.
Thanks,
Ingo
prev parent reply other threads:[~2015-03-25 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 1:59 [PATCH] Fix braces to GNU style carlossilveirajr
2015-03-25 8:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325085840.GA32673@gmail.com \
--to=mingo@kernel.org \
--cc=carlossilveirajr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.