From: Ralf Baechle <ralf@linux-mips.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: david.daney@cavium.com, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, lrosenboim@caviumnetworks.com,
aleksey.makarov@auriga.com
Subject: Re: Enable little endian kernel: misspelled Kconfig item
Date: Wed, 25 Mar 2015 10:12:08 +0100 [thread overview]
Message-ID: <20150325091208.GG1385@linux-mips.org> (raw)
In-Reply-To: <20150325075720.GA18552@station.rsr.lip6.fr>
On Wed, Mar 25, 2015 at 08:57:20AM +0100, Valentin Rothberg wrote:
> Hi David,
>
> your commit 9861908f081f ("MIPS: OCTEON: Enable little endian kernel.")
> adds the following conditional select to arch/mips/Kconfig:
>
> + select SYS_SUPPORTS_HOTPLUG_CPU if CONFIG_CPU_BIG_ENDIAN
>
> The problem is the 'CONFIG_' prefix for 'CPU_BIG_ENDIAN'. The item is
> always off since the prefix does not work as we are in a Kconfig file.
> Hence, the if-statement never evaluates to true.
>
> It can be fixed by simply removing the 'CONFIG_' prefix.
>
> I detected this commit with ./scripts/checkkconfigsymbols.py. Commit
> b1a3f243485f ("checkkconfigsymbols.py: make it Git aware") added support
> to check (and compare) undefined Kconfig symbols in Git commits.
I've folded in a fix for the issue.
Ralf
prev parent reply other threads:[~2015-03-25 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 7:57 Enable little endian kernel: misspelled Kconfig item Valentin Rothberg
2015-03-25 9:12 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325091208.GG1385@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=aleksey.makarov@auriga.com \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=lrosenboim@caviumnetworks.com \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.