All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Oleg Nesterov <oleg@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Alexei Starovoitov <ast@plumgrid.com>,
	Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] x86/asm/entry/64: use smaller insns
Date: Thu, 26 Mar 2015 11:25:51 +0100	[thread overview]
Message-ID: <20150326102551.GC27751@pd.tnic> (raw)
In-Reply-To: <CAK1hOcO+Z+1z7AMvTjH9efATMRaMN-pSvP4kdEJYXPPfLU_-oA@mail.gmail.com>

On Thu, Mar 26, 2015 at 11:07:42AM +0100, Denys Vlasenko wrote:
> In my experiment, GAS uses 10-byte insn only for constants which
> won't work with 7-byte encoding; or if I explicitly ask for "movabs":
> 
> _start:         .globl  _start
>                 mov $0x12345678,%edi  # 5 bytes
>                 mov $0x12345678,%rdi  # 7 bytes
>                 movq $0x12345678,%rdi  # 7 bytes
>                 mov $0x80000000,%rdi  # 10 bytes

Right, and since they're signed immediates, the AUDIT_ARCH_X86_64 thing
is 0xc000003e and does not fit in an s32, thus the 64-bit immediate with
bf opcode:

	mov $0x80000000-1,%rdi
	mov $0x80000000,%rdi
	mov $0xc000003e,%rdi
	mov $0xc000003e,%edi

...

  21:   48 c7 c7 ff ff ff 7f    mov    $0x7fffffff,%rdi
  28:   48 bf 00 00 00 80 00    movabs $0x80000000,%rdi
  2f:   00 00 00 
  32:   48 bf 3e 00 00 c0 00    movabs $0xc000003e,%rdi
  39:   00 00 00
  3c:   bf 3e 00 00 c0          mov    $0xc000003e,%edi

Makes sense to me.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

  parent reply	other threads:[~2015-03-26 10:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 17:18 [PATCH 1/4] x86/asm/entry/64: better label name, fix comments Denys Vlasenko
2015-03-25 17:18 ` [PATCH 2/4] x86/asm/entry/64: do not TRACE_IRQS fast SYSRET64 path Denys Vlasenko
2015-03-25 17:29   ` Ingo Molnar
2015-03-25 17:41     ` Denys Vlasenko
2015-03-25 18:04       ` Ingo Molnar
2015-03-25 18:19         ` Denys Vlasenko
2015-03-25 17:18 ` [PATCH 3/4] x86/asm/entry/64: use smaller insns Denys Vlasenko
2015-03-25 18:03   ` Andy Lutomirski
2015-03-25 23:51   ` Linus Torvalds
2015-03-25 23:56     ` H. Peter Anvin
2015-03-26  0:05       ` Linus Torvalds
2015-03-26  0:12         ` H. Peter Anvin
2015-03-26  9:27         ` Borislav Petkov
2015-03-26  9:37           ` Ingo Molnar
2015-03-26  9:51             ` Borislav Petkov
2015-03-26 10:07             ` Denys Vlasenko
2015-03-26 10:25               ` Ingo Molnar
2015-03-26 10:53                 ` Denys Vlasenko
2015-03-26 10:25               ` Borislav Petkov [this message]
2015-03-26  9:30     ` Ingo Molnar
2015-03-27 11:47   ` [tip:x86/asm] x86/asm/entry/64: Use smaller instructions tip-bot for Denys Vlasenko
2015-03-25 17:18 ` [PATCH 4/4] x86/asm/entry/64: fix typo in comment Denys Vlasenko
2015-03-27 11:46 ` [tip:x86/asm] x86/asm/entry/64: Use better label name, fix comments tip-bot for Denys Vlasenko
2015-03-27 12:15   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326102551.GC27751@pd.tnic \
    --to=bp@alien8.de \
    --cc=ast@plumgrid.com \
    --cc=dvlasenk@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vda.linux@googlemail.com \
    --cc=wad@chromium.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.