From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com. [209.85.212.175]) by gmr-mx.google.com with ESMTPS id sf8si450161wic.2.2015.03.26.07.18.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Mar 2015 07:18:16 -0700 (PDT) Received: by mail-wi0-f175.google.com with SMTP id g7so17605688wib.1 for ; Thu, 26 Mar 2015 07:18:16 -0700 (PDT) Date: Thu, 26 Mar 2015 14:18:12 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: rtc-linux@googlegroups.com, Sangbeom Kim , Samuel Ortiz , Alessandro Zummo , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Chanwoo Choi Subject: Re: [rtc-linux] Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13 Message-ID: <20150326141812.GO5951@x1> References: <1426586058-15987-1-git-send-email-k.kozlowski@samsung.com> <1426586058-15987-2-git-send-email-k.kozlowski@samsung.com> <20150323123458.GE24804@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote: > 2015-03-23 13:34 GMT+01:00 Lee Jones : > > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > > > >> From: Chanwoo Choi > >> > >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's= RTC is > >> equal to S2MPS14's RTC. > >> > >> Cc: Lee Jones > >> Suggested-by: Krzysztof Kozlowski > >> Signed-off-by: Chanwoo Choi > >> Signed-off-by: Krzysztof Kozlowski > >> > >> --- > >> > >> Changes since v1: > >> 1. New patch. > >> --- > >> drivers/mfd/sec-core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. >=20 > Hi, >=20 > Sorry for the mess but we did this wrong. > The S2MPS13 RTC is slightly different than S2MPS14 and that difference > is important. It is embarrassing... but the difference was written > small-print as a note in datasheet. Really. I found it after carefully > comparing two PDFs. The impact of difference was not detected because > of error in DTS for Exynos5433-based board. >=20 > This patch should be dropped (or reverted) and "s2mps13-rtc" should be > used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should > have its own support for RTC which I will add in separate patch. >=20 > Lee, once again sorry for the mess. How would you like to proceed? Can > you just drop this commit? Patch removed -- panic averted. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [rtc-linux] Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13 Date: Thu, 26 Mar 2015 14:18:12 +0000 Message-ID: <20150326141812.GO5951@x1> References: <1426586058-15987-1-git-send-email-k.kozlowski@samsung.com> <1426586058-15987-2-git-send-email-k.kozlowski@samsung.com> <20150323123458.GE24804@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f172.google.com ([209.85.212.172]:36601 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251AbbCZOSS (ORCPT ); Thu, 26 Mar 2015 10:18:18 -0400 Received: by wibg7 with SMTP id g7so150332975wib.1 for ; Thu, 26 Mar 2015 07:18:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski Cc: rtc-linux@googlegroups.com, Sangbeom Kim , Samuel Ortiz , Alessandro Zummo , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Chanwoo Choi On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote: > 2015-03-23 13:34 GMT+01:00 Lee Jones : > > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > > > >> From: Chanwoo Choi > >> > >> This patch modify the RTC compatible name of S2MPS13 because S2MPS= 13's RTC is > >> equal to S2MPS14's RTC. > >> > >> Cc: Lee Jones > >> Suggested-by: Krzysztof Kozlowski > >> Signed-off-by: Chanwoo Choi > >> Signed-off-by: Krzysztof Kozlowski > >> > >> --- > >> > >> Changes since v1: > >> 1. New patch. > >> --- > >> drivers/mfd/sec-core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. >=20 > Hi, >=20 > Sorry for the mess but we did this wrong. > The S2MPS13 RTC is slightly different than S2MPS14 and that differenc= e > is important. It is embarrassing... but the difference was written > small-print as a note in datasheet. Really. I found it after carefull= y > comparing two PDFs. The impact of difference was not detected because > of error in DTS for Exynos5433-based board. >=20 > This patch should be dropped (or reverted) and "s2mps13-rtc" should b= e > used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should > have its own support for RTC which I will add in separate patch. >=20 > Lee, once again sorry for the mess. How would you like to proceed? Ca= n > you just drop this commit? Patch removed -- panic averted. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog