From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x Date: Thu, 26 Mar 2015 08:22:04 -0700 Message-ID: <20150326152204.GF31346@atomide.com> References: <1426080210-841-1-git-send-email-peter.ujfalusi@ti.com> <1426080210-841-4-git-send-email-peter.ujfalusi@ti.com> <20150326105603.GK32683@intel.com> <5513FC22.2030304@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5513FC22.2030304-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Ujfalusi Cc: Vinod Koul , linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nm-l0cyMroinI0@public.gmane.org List-Id: linux-omap@vger.kernel.org * Peter Ujfalusi [150326 05:32]: > On 03/26/2015 12:56 PM, Vinod Koul wrote: > >> + > >> +static void ti_dma_xbar_free(struct device *dev, void *route_data) > >> +{ > >> + struct ti_dma_xbar_data *xbar = dev_get_drvdata(dev); > >> + struct ti_dma_xbar_map *map = route_data; > >> + > >> + dev_dbg(dev, "Unmapping XBAR%d (was routed to %d)\n", > >> + map->xbar_in, map->xbar_out); > >> + > >> + regmap_write(xbar->regmap, map->xbar_out * 2, 0); > > just out of curiosity how much do you save using regmap :) > > good point, not much I guess. I had it implemented w/o regmap as well, but > thought why not use regmap if it is available. Regmap is nice for slow devices and devices in a shared register range like the omap syscon general area. For normal use, there's quite a bit of overhead with regmap compared to just read/write :) Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 26 Mar 2015 08:22:04 -0700 Subject: [PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x In-Reply-To: <5513FC22.2030304@ti.com> References: <1426080210-841-1-git-send-email-peter.ujfalusi@ti.com> <1426080210-841-4-git-send-email-peter.ujfalusi@ti.com> <20150326105603.GK32683@intel.com> <5513FC22.2030304@ti.com> Message-ID: <20150326152204.GF31346@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Peter Ujfalusi [150326 05:32]: > On 03/26/2015 12:56 PM, Vinod Koul wrote: > >> + > >> +static void ti_dma_xbar_free(struct device *dev, void *route_data) > >> +{ > >> + struct ti_dma_xbar_data *xbar = dev_get_drvdata(dev); > >> + struct ti_dma_xbar_map *map = route_data; > >> + > >> + dev_dbg(dev, "Unmapping XBAR%d (was routed to %d)\n", > >> + map->xbar_in, map->xbar_out); > >> + > >> + regmap_write(xbar->regmap, map->xbar_out * 2, 0); > > just out of curiosity how much do you save using regmap :) > > good point, not much I guess. I had it implemented w/o regmap as well, but > thought why not use regmap if it is available. Regmap is nice for slow devices and devices in a shared register range like the omap syscon general area. For normal use, there's quite a bit of overhead with regmap compared to just read/write :) Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753360AbbCZP02 (ORCPT ); Thu, 26 Mar 2015 11:26:28 -0400 Received: from muru.com ([72.249.23.125]:40011 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbbCZP0Y (ORCPT ); Thu, 26 Mar 2015 11:26:24 -0400 Date: Thu, 26 Mar 2015 08:22:04 -0700 From: Tony Lindgren To: Peter Ujfalusi Cc: Vinod Koul , linux@arm.linux.org.uk, grant.likely@linaro.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, nm@ti.com Subject: Re: [PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x Message-ID: <20150326152204.GF31346@atomide.com> References: <1426080210-841-1-git-send-email-peter.ujfalusi@ti.com> <1426080210-841-4-git-send-email-peter.ujfalusi@ti.com> <20150326105603.GK32683@intel.com> <5513FC22.2030304@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5513FC22.2030304@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Ujfalusi [150326 05:32]: > On 03/26/2015 12:56 PM, Vinod Koul wrote: > >> + > >> +static void ti_dma_xbar_free(struct device *dev, void *route_data) > >> +{ > >> + struct ti_dma_xbar_data *xbar = dev_get_drvdata(dev); > >> + struct ti_dma_xbar_map *map = route_data; > >> + > >> + dev_dbg(dev, "Unmapping XBAR%d (was routed to %d)\n", > >> + map->xbar_in, map->xbar_out); > >> + > >> + regmap_write(xbar->regmap, map->xbar_out * 2, 0); > > just out of curiosity how much do you save using regmap :) > > good point, not much I guess. I had it implemented w/o regmap as well, but > thought why not use regmap if it is available. Regmap is nice for slow devices and devices in a shared register range like the omap syscon general area. For normal use, there's quite a bit of overhead with regmap compared to just read/write :) Regards, Tony