From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: linux-next: build warnings after merge of the access_once tree Date: Thu, 26 Mar 2015 17:44:42 +0100 Message-ID: <20150326164441.GH24151@twins.programming.kicks-ass.net> References: <20150326193112.2c87eb39@canb.auug.org.au> <20150326103442.GV21418@twins.programming.kicks-ass.net> <20150326132750.GA2805@arm.com> <20150326142220.GY21418@twins.programming.kicks-ass.net> <20150326163647.GC21418@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150326163647.GC21418@twins.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Will Deacon , Stephen Rothwell , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Davidlohr Bueso , Paul McKenney List-Id: linux-next.vger.kernel.org On Thu, Mar 26, 2015 at 05:36:47PM +0100, Peter Zijlstra wrote: > Can't we make an argument that these barrier calls are not required? The > memcpy() call already guarantees we emit the loads and its opaque so the > compiler cannot 'cache' the value. So I see not immediate reason for the > dual memory clobber. Oh wait, it needs to reassess the content of the target variable after the memcpy of course. Could we then at least make the 64bit case unconditional as well?