From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbCtk-0002gP-Cg for qemu-devel@nongnu.org; Thu, 26 Mar 2015 14:52:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbCth-0006SO-5B for qemu-devel@nongnu.org; Thu, 26 Mar 2015 14:52:56 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:9337 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbCtg-0006S3-Uh for qemu-devel@nongnu.org; Thu, 26 Mar 2015 14:52:53 -0400 Date: Thu, 26 Mar 2015 19:52:50 +0100 From: Alberto Garcia Message-ID: <20150326185250.GA23415@igalia.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On Thu, Mar 26, 2015 at 07:24:54PM +0200, Alberto Garcia wrote: > - The creation/destruction of ThrottleTimers is now handled internally > when a BlockDriverState is added/removed from a group, since > there's not much point on keeping them separate. This also hides > the timer callbacks from the outside, which makes things a bit > nicer and easier for some of the other changes included in these > series. Hmm... this actually breaks the new test because now BDS are required to have an AioContext attached when they're added to a group, which doesn't happen in qtest: bdrv = bdrv_new(); throttle_group_register_bs(bdrv, "bar"); I'm unsure of how to proceed with this, I don't see a clear way to attach the AioContext here (unless I do bdrv->aio_context = ctx). Suggestions are welcome. Berto