All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Hung <hpeter@gmail.com>
Cc: jslaby@suse.cz, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
	peter_hong@fintek.com.tw,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 RESEND 0/2] serial: 8250_pci: Fintek products patches
Date: Thu, 26 Mar 2015 22:23:01 +0100	[thread overview]
Message-ID: <20150326212301.GA12137@kroah.com> (raw)
In-Reply-To: <1426586535-6900-1-git-send-email-hpeter+linux_kernel@gmail.com>

On Tue, Mar 17, 2015 at 06:02:13PM +0800, Peter Hung wrote:
> These series patches works for Fintek F81504/F81508/F81512 PCI to Serial Port.
> and patch 0002 is following with patch 0001.
> 
> patch 0001 is just cleanup non-used source code.
> patch 0002 is major patch.
> 
> The serial port of our product will failed after wakeup from S3(STR).
> 
> It's due to when the system wakeup from S3(STR), this PCI device's
> configuration space from 0x40 to 0x40 + max_port * 0x08 should be
> re-configured. If had no re-configure, It's will all zero.
> 
> We move all initialization from pci_fintek_setup() to pci_fintek_init() and
> set it to pci_serial_quirks struct .init section. It's will re-init this 
> device when system wakeup from pciserial_resume_ports().

What changed from version 1?

> Peter Hung (2):
>   serial: 8250_pci: remove non-used var for F81504
>   serial: 8250_pci: port failed after wakeup from S3
> 
>  drivers/tty/serial/8250/8250_pci.c | 121 +++++++++++++++----------------------
>  1 file changed, 50 insertions(+), 71 deletions(-)
>  mode change 100644 => 100755 drivers/tty/serial/8250/8250_pci.c

You can't change the mode of a kernel file to executable, that's not
allowed, and is a bug somewhere in your editor.

Please fix this up and resend the series, I can't take these as-is.

thanks,

greg k-h

      parent reply	other threads:[~2015-03-26 21:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 10:02 [PATCH V2 RESEND 0/2] serial: 8250_pci: Fintek products patches Peter Hung
2015-03-17 10:02 ` [PATCH V2 RESEND 1/2] serial: 8250_pci: remove non-used var for F81504 Peter Hung
2015-03-17 10:02 ` [PATCH V2 RESEND 2/2] serial: 8250_pci: port failed after wakeup from S3 Peter Hung
2015-03-26 21:23 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326212301.GA12137@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    --cc=tom_tsai@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.