From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753806AbbC0HpU (ORCPT ); Fri, 27 Mar 2015 03:45:20 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37105 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753015AbbC0HpR (ORCPT ); Fri, 27 Mar 2015 03:45:17 -0400 Date: Fri, 27 Mar 2015 08:46:57 +0100 From: Daniel Vetter To: Imre Deak Cc: Greg Kroah-Hartman , Jesse Barnes , Daniel Vetter , Peter Hurley , Jiri Slaby , Linux Kernel Mailing List Subject: Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order Message-ID: <20150327074657.GA23521@phenom.ffwll.local> Mail-Followup-To: Imre Deak , Greg Kroah-Hartman , Jesse Barnes , Peter Hurley , Jiri Slaby , Linux Kernel Mailing List References: <1418725405.3185.31.camel@ideak-mobl> <54902AA1.7080301@hurleysoftware.com> <1418740692.7338.33.camel@intelbox> <5490491E.70102@hurleysoftware.com> <1418746939.7338.56.camel@intelbox> <549068A4.3020702@hurleysoftware.com> <55146509.4020809@virtuousgeek.org> <20150326210141.GD5481@kroah.com> <1427403945.3324.44.camel@ideak-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427403945.3324.44.camel@ideak-mobl> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 11:05:45PM +0200, Imre Deak wrote: > On Thu, 2015-03-26 at 22:01 +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 26, 2015 at 12:59:05PM -0700, Jesse Barnes wrote: > > > On 12/16/2014 09:42 AM, Daniel Vetter wrote: > > > > On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley wrote: > > > >> On 12/16/2014 11:22 AM, Imre Deak wrote: > > > >>> On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote: > > > >>>> Fine. Just another expedient fix piled on top of other expedient fixes > > > >>>> that go back past 3.9 with no end in sight. > > > >>> > > > >>> I'm also happy to look into narrowing down the scope of console_lock in > > > >>> fbdev/fbcon as was suggested. But doing that as a follow-up to this > > > >>> change still makes sense to me since it will take more time and have the > > > >>> risk of regressions that are not related to what this change fixes. > > > >> > > > >> I apologize for my tone. I'm not blaming you for the current situation, > > > >> nor is it your responsibility to go fix vt/fbcon/fbdev driver stack > > > >> inversion. I'm just trying to bring some awareness of the larger scope, > > > >> so that collectively we take action and resolve the underlying problems. > > > > > > > > Yeah I guess I should tune down my NACK to a Grumpy-if-merged-by too. > > > > We have a lot of nonoptimal solutions at hand here :( > > > > > > So where does that leave us with this fix? Should we wait for someone > > > to come along and do all the rework? Imre said he'd be willing to do > > > it, but still feels this fix makes sense > > > > > > Or we could just abandon the fb layer altogether (my preference). In > > > that case fixing this is fine, since we'll be able to ignore it for > > > configs that switch over to using !fbdev and kmscon. > > > > I think I already merged the patches a while ago :) > > Yes, but only the first two patches. This third one is not merged > AFAICS. Yeah there was a big discussion in that one which eventualy resulted in my grumpy ack and my nack retracted. So fwiw Reviewed-by: Daniel Vetter on 3/3. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch