All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
	David Kershner <david.kershner@unisys.com>,
	sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: unisys: use error codes
Date: Fri, 27 Mar 2015 15:15:18 +0530	[thread overview]
Message-ID: <20150327094518.GA10353@sudip-PC> (raw)
In-Reply-To: <20150327084716.GB1250@kroah.com>

On Fri, Mar 27, 2015 at 09:47:16AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 27, 2015 at 02:00:58PM +0530, Sudip Mukherjee wrote:
> >  	}
> >  	rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1);
> >  	if (rc  < 0) {
> >  		unregister_chrdev_region(major_dev, 1);
> > -		return -1;
> > +		return rc;
> 
> I should have kept reading in the patch series, nice fix up :)
some effect of learning from you and Dan :)

thanks

  reply	other threads:[~2015-03-27  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27  8:30 [PATCH 1/3] staging: unisys: unregister chardev on error Sudip Mukherjee
2015-03-27  8:30 ` [PATCH 2/3] staging: unisys: use error codes Sudip Mukherjee
2015-03-27  8:47   ` Greg Kroah-Hartman
2015-03-27  9:45     ` Sudip Mukherjee [this message]
2015-03-27  8:30 ` [PATCH 3/3] staging: unisys: remove forward declaration Sudip Mukherjee
2015-03-27  8:46 ` [PATCH 1/3] staging: unisys: unregister chardev on error Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150327094518.GA10353@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.