From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753225AbbC0MLI (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Mar 2015 08:11:08 -0400
Received: from mail-wg0-f47.google.com ([74.125.82.47]:34645 "EHLO
	mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752666AbbC0MLD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Mar 2015 08:11:03 -0400
Date: Fri, 27 Mar 2015 13:10:58 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Bandan Das <bsd@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/apic: remove read/write test in verify_local_apic()
Message-ID: <20150327121058.GA15631@gmail.com>
References: <jpgtwxiuj99.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <jpgtwxiuj99.fsf@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Bandan Das <bsd@redhat.com> wrote:

> 
> Most newer processors have the APIC_ID read-only and this
> test probably fails on most boxes anyway. Fix typos.
> 
> Signed-off-by: Bandan Das <bsd@redhat.com>
> ---
> Honestly, I don't think this function is really needed.
> It's called for both UP/MP but the return value isn't
> used by any of them. Maybe, we should just remove it ?

Agreed, lets just remove it.

Thanks,

	Ingo