Re: [nft PATCH 2/3] src: add xt compat support

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Mar 27, 2015 at 01:59:31PM +0100, Arturo Borrero Gonzalez wrote:
> On 27 March 2015 at 13:31, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Fri, Mar 27, 2015 at 01:00:37PM +0100, Arturo Borrero Gonzalez wrote:
> >> On 25 March 2015 at 20:44, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >> > On Wed, Mar 25, 2015 at 08:16:02PM +0100, Arturo Borrero Gonzalez wrote:
> >> >> diff --git a/include/xt.h b/include/xt.h
> >> >> new file mode 100644
> >> >> index 0000000..414f3d1
> >> >> --- /dev/null
> >> >> +++ b/include/xt.h
> >> >> @@ -0,0 +1,100 @@
> >> >> +#ifndef _NFT_XT_H_
> >> >> +#define _NFT_XT_H_
> >> >> +
> >> >> +#include <arpa/inet.h>
> >> >> +#include <netinet/in.h>
> >> >> +#include <limits.h>
> >> >> +#include <net/if.h>
> >> >> +#include <net/ethernet.h>
> >> >> +
> >> >> +struct netlink_linearize_ctx;
> >> >> +struct netlink_parse_ctx;
> >> >> +struct nft_rule_expr;
> >> >> +struct rule_pp_ctx;
> >> >> +struct rule;
> >> >> +
> >> >> +#ifdef HAVE_LIBXTABLES
> >> >> +
> >> >> +#include <linux/netfilter_ipv4/ip_tables.h>
> >> >> +#include <linux/netfilter_ipv6/ip6_tables.h>
> >> >> +#include <linux/netfilter_arp/arp_tables.h>
> >> >> +
> >> >> +/* Fake ebt_entry */
> >> >> +struct ebt_entry {
> >> >
> >> > I think you can avoid this if you:
> >> >
> >> > #include <linux/netfilter_bridge/ebtables.h>
> >> >
> >>
> >> Can't include <linux/netfilter_bridge/ebtables.h> because it includes
> >> <linux/if.h> and clash with <net/if.h>
> >
> > There must be a clean way to fix this without embedding the ebt_entry
> > structure.
> >
> 
> We seem to have the same problem in ebtables-compat:
> 
> http://git.netfilter.org/iptables/tree/iptables/nft-bridge.h#n32

Try to find a way to fix it there too ;-)