All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Gospodarek <gospo@cumulusnetworks.com>
To: Robert Shearman <rshearma@brocade.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Bjornar Ness <bjornar.ness@gmail.com>,
	Sowmini Varadhan <sowmini05@gmail.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [RFC net-next 1/2] net: allow user to set IPv6 nexthop for IPv4 route
Date: Fri, 27 Mar 2015 10:10:57 -0400	[thread overview]
Message-ID: <20150327141057.GG1051@gospo> (raw)
In-Reply-To: <5515449D.4080408@brocade.com>

On Fri, Mar 27, 2015 at 11:53:01AM +0000, Robert Shearman wrote:
> On 26/03/15 21:05, Andy Gospodarek wrote:
> >diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> >index bea910f..26cdd01 100644
> >--- a/include/uapi/linux/rtnetlink.h
> >+++ b/include/uapi/linux/rtnetlink.h
> >@@ -306,6 +306,7 @@ enum rtattr_type_t {
> >         RTA_VIA,
> >         RTA_NEWDST,
> >         RTA_PREF,
> >+       RTA_GATEWAY6,
> 
> There shouldn't be any need to add a new attribute. The RTA_VIA attribute
> that Eric Biederman recently introduced should have the semantics that you
> require:
> 
> "RTA_VIA specifies the specifies the next machine to send a packet to
> like RTA_GATEWAY.  RTA_VIA differs from RTA_GATEWAY in that it
> includes the address family of the address of the next machine to send
> a packet to."

Absolutely.  I did this first set before Eric added the RTA_VIA
attribute, so I need to not only use it, but also add support in the
ipv4 code to use that attribute if set.

  reply	other threads:[~2015-03-27 14:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 21:05 [RFC net-next/iproute2 0/2] net: infrastructure to support RFC-5549 Andy Gospodarek
2015-03-26 21:05 ` [RFC net-next 1/2] net: allow user to set IPv6 nexthop for IPv4 route Andy Gospodarek
2015-03-26 21:42   ` Sowmini Varadhan
2015-03-26 23:12   ` Julian Anastasov
2015-03-27  0:27     ` Andy Gospodarek
2015-03-27 11:53   ` Robert Shearman
2015-03-27 14:10     ` Andy Gospodarek [this message]
     [not found]       ` <CAJO99TkSaJjmvTjWOpnMLwNaf7A-q9_DvkppT+M77rSV0Syh0w@mail.gmail.com>
2015-04-08  2:52         ` Andy Gospodarek
2015-03-27 13:23   ` Sowmini Varadhan
2015-03-27 14:35     ` Andy Gospodarek
2015-03-27 14:37       ` Sowmini Varadhan
2015-03-26 21:05 ` [RFC iproute2 2/2] iproute2: " Andy Gospodarek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150327141057.GG1051@gospo \
    --to=gospo@cumulusnetworks.com \
    --cc=bjornar.ness@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=rshearma@brocade.com \
    --cc=sowmini05@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.