From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org,
Haavard Skinnemoen
<hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i2c: i2c-gpio: fix some of gpio sleep issues
Date: Fri, 27 Mar 2015 16:46:09 +0100 [thread overview]
Message-ID: <20150327154609.GD27238@katana> (raw)
In-Reply-To: <1426593869-8724-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Tue, Mar 17, 2015 at 12:04:29PM +0000, Ben Dooks wrote:
> The i2c-gpio driver can be used in systems where the GPIO itself is
> provided by a GPIO driver that may be sleeping (for example, SPI or
> USB). In this case, it is preferable to use the _cansleep() variants
> of the GPIO code.
>
> We can only fix this up for the case where the i2c-gpio implementation
> provides open-drain outputs as there are no gpio_direction_xxx_cansleep()
> provided.
>
> This removes the issues on the customer system with the console constantly
> showing the following warning:
>
> WARNING: CPU: 0 PID: 1 at drivers/gpio/gpiolib.c:2389 gpiod_set_raw_value
??? It will silence a warning but will totally break the timing in case
sleeping is needed? I'd think the warning is very suitable.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-27 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 12:04 [PATCH] i2c: i2c-gpio: fix some of gpio sleep issues Ben Dooks
[not found] ` <1426593869-8724-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-03-27 15:46 ` Wolfram Sang [this message]
2015-04-22 8:40 ` Ben Dooks
[not found] ` <55375E6B.9050405-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-04-22 8:43 ` [Linux-kernel] " Ben Dooks
2015-04-22 9:05 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327154609.GD27238@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org \
--cc=hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.