From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Xen Coverity Team <coverity@xen.org>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/xen-mfndump: Remove stray semicolon preventing 'dump-m2p' from functioning
Date: Fri, 27 Mar 2015 14:53:00 -0400 [thread overview]
Message-ID: <20150327185300.GA3269@l.oracle.com> (raw)
In-Reply-To: <1427481892-895-1-git-send-email-andrew.cooper3@citrix.com>
On Fri, Mar 27, 2015 at 06:44:52PM +0000, Andrew Cooper wrote:
> Introduced by c/s 1781f00e
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Coverity-IDs: 1291939 (stray semicolon), 1291941 (structually dead code)
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Xen Coverity Team <coverity@xen.org>
> ---
> tools/misc/xen-mfndump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/misc/xen-mfndump.c b/tools/misc/xen-mfndump.c
> index 0c018e0..ceeeaa9 100644
> --- a/tools/misc/xen-mfndump.c
> +++ b/tools/misc/xen-mfndump.c
> @@ -41,7 +41,7 @@ int dump_m2p_func(int argc, char *argv[])
> }
>
> /* Map M2P and obtain gpfn */
> - if ( xc_maximum_ram_page(xch, &max_mfn) < 0 );
> + if ( xc_maximum_ram_page(xch, &max_mfn) < 0 )
> {
> ERROR("Failed to get the maximum mfn");
> return -1;
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2015-03-27 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 18:44 [PATCH] tools/xen-mfndump: Remove stray semicolon preventing 'dump-m2p' from functioning Andrew Cooper
2015-03-27 18:53 ` Konrad Rzeszutek Wilk [this message]
2015-03-30 9:06 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327185300.GA3269@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=coverity@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.