All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Max Kirillov <max@max630.net>, git@vger.kernel.org
Subject: Re: [question] && chaining vs shell loops
Date: Sun, 29 Mar 2015 13:43:13 -0400	[thread overview]
Message-ID: <20150329174312.GA6680@peff.net> (raw)
In-Reply-To: <874mp3948k.fsf@igel.home>

On Sun, Mar 29, 2015 at 06:07:39PM +0200, Andreas Schwab wrote:

> Max Kirillov <max@max630.net> writes:
> 
> > As far as I can see, loops in shell ignore non-zero exit
> > codes of the bodies which are not last. For example, exit
> > code of command 'for f in false true; do $f; done' is 0,
> > even if there was false.
> 
> There is nothing special with loops, that's how the exit code of
> compound commands is defined in general: it's the exit code of the last
> executed command.

Yes, but that makes it problematic if you want to know if any of the
loop iterations failed. Doing:

  for f in false true; do $f || break; done

doesn't work, because the "break" has exit code 0. Doing:

  (for f in false true; do $f || exit 1; done)

works. In our test scripts, it is also OK to just "return 1", because
the test snippets execute inside a function.

If you have other solutions, I'd love to hear them. I just fixed several
of these loops recently, and I couldn't come up with anything more
clever.

-Peff

  reply	other threads:[~2015-03-29 17:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-29 15:48 [question] && chaining vs shell loops Max Kirillov
2015-03-29 16:07 ` Andreas Schwab
2015-03-29 17:43   ` Jeff King [this message]
2015-03-30  6:29     ` Max Kirillov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150329174312.GA6680@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=max@max630.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.