From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 01/86] pci: export pci_ids.h Date: Sun, 29 Mar 2015 22:40:47 +0200 Message-ID: <20150329204047.GA5902@kroah.com> References: <1427635734-24786-1-git-send-email-mst@redhat.com> <1427635734-24786-2-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1427635734-24786-2-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Michael S. Tsirkin" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bjorn Helgaas , Jonathan Corbet , "David S. Miller" , Hans Verkuil , Mauro Carvalho Chehab , Alexei Starovoitov , stephen hemminger , Masahiro Yamada , Andy Shevchenko , Andy Lutomirski , Rasmus Villemoes , Stephane Eranian , Huang Rui , Peter Neubauer , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Sun, Mar 29, 2015 at 03:37:01PM +0200, Michael S. Tsirkin wrote: > The macros in pci_ids.h are pretty useful for userspace > using the pci sysfs interface. > At the moment userspace is forced to duplicate these macros > (e.g. QEMU does this), it is better to expose them in > /usr/include/linux/pci_ids.h so everyone can just include > this header. > > Signed-off-by: Michael S. Tsirkin > --- > include/linux/pci_ids.h | 2998 +----------------------------------------- > include/uapi/linux/pci_ids.h | 2997 +++++++++++++++++++++++++++++++++++++++++ No, please use the pci ids file from the upstream pci id database instead. We shouldn't be putting these all in one file, and pulling them out of drivers isn't ok. Userspace shouldn't need to know any of these, use libpci. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 29 Mar 2015 22:40:47 +0200 From: Greg KH To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Jonathan Corbet , "David S. Miller" , Hans Verkuil , Mauro Carvalho Chehab , Alexei Starovoitov , stephen hemminger , Masahiro Yamada , Andy Shevchenko , Andy Lutomirski , Rasmus Villemoes , Stephane Eranian , Huang Rui , Peter Neubauer , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 01/86] pci: export pci_ids.h Message-ID: <20150329204047.GA5902@kroah.com> References: <1427635734-24786-1-git-send-email-mst@redhat.com> <1427635734-24786-2-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1427635734-24786-2-git-send-email-mst@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sun, Mar 29, 2015 at 03:37:01PM +0200, Michael S. Tsirkin wrote: > The macros in pci_ids.h are pretty useful for userspace > using the pci sysfs interface. > At the moment userspace is forced to duplicate these macros > (e.g. QEMU does this), it is better to expose them in > /usr/include/linux/pci_ids.h so everyone can just include > this header. > > Signed-off-by: Michael S. Tsirkin > --- > include/linux/pci_ids.h | 2998 +----------------------------------------- > include/uapi/linux/pci_ids.h | 2997 +++++++++++++++++++++++++++++++++++++++++ No, please use the pci ids file from the upstream pci id database instead. We shouldn't be putting these all in one file, and pulling them out of drivers isn't ok. Userspace shouldn't need to know any of these, use libpci. thanks, greg k-h