From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcPNH-0000et-WE for qemu-devel@nongnu.org; Sun, 29 Mar 2015 22:24:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcPNG-0005Vv-Vl for qemu-devel@nongnu.org; Sun, 29 Mar 2015 22:24:23 -0400 Date: Mon, 30 Mar 2015 13:25:16 +1100 From: David Gibson Message-ID: <20150330022516.GC9908@voom.fritz.box> References: <1427449798-10345-1-git-send-email-nikunj@linux.vnet.ibm.com> <5518B259.1070609@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sgneBHv3152wZ8jf" Content-Disposition: inline In-Reply-To: <5518B259.1070609@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Nikunj A Dadhania , agraf@suse.de --sgneBHv3152wZ8jf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote: > On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote: > >Each hardware instance has a platform unique location code. The OF > >device tree that describes a part of a hardware entity must include > >the =E2=80=9Cibm,loc-code=E2=80=9D property with a value that represents= the location > >code for that hardware entity. > > > >Introduce an hcall to populate ibm,loc-code. > >1) PCI passthru devices need to identify with its own ibm,loc-code > > available on the host. > >2) Emulated devices encode as following: qemu_:. > > > >Signed-off-by: Nikunj A Dadhania [snip] > >diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > >index af71e8b..95157ac 100644 > >--- a/include/hw/ppc/spapr.h > >+++ b/include/hw/ppc/spapr.h > >@@ -310,7 +310,10 @@ typedef struct sPAPREnvironment { > > #define KVMPPC_H_LOGICAL_MEMOP (KVMPPC_HCALL_BASE + 0x1) > > /* Client Architecture support */ > > #define KVMPPC_H_CAS (KVMPPC_HCALL_BASE + 0x2) > >-#define KVMPPC_HCALL_MAX KVMPPC_H_CAS > >+#define KVMPPC_H_RTAS_UPDATE (KVMPPC_HCALL_BASE + 0x3) > >+#define KVMPPC_H_REPORT_MC_ERR (KVMPPC_HCALL_BASE + 0x4) > >+#define KVMPPC_H_GET_LOC_CODE (KVMPPC_HCALL_BASE + 0x5) > >+#define KVMPPC_HCALL_MAX KVMPPC_H_GET_LOC_CODE >=20 >=20 > Please add only relevant codes. And what happened to patches adding > H_RTAS_UPDATE and H_REPORT_MC_ERR? >=20 > Also (it is probably a very stupid question but still :) ), why are all > these callbacks - hypercalls, not RTAS calls? The hypercalls are numbered= in > sPAPR and we kind of stealing numbers from that space while we are > allocating RTAS tokens ourselves and have more freedom. Also, I thought the plan was to remove PCI device enumeration from SLOF and move it to qemu (since we need to partially do that for hotplug). That removes the need for the hcall entirely. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --sgneBHv3152wZ8jf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVGLQLAAoJEGw4ysog2bOS8OQP/3frB/Okz/JV/7BrYRzgBjJx HycITWLIDt1wZv9g1j8yGY3j5W/SBnGgtDZFVulCP40FRvo2dGoADzNSL/992vWf BBWqs+Fq/KalVIBeCeDW1oo1b3+G/TrO/47xzCVK1SBekTjXetF4bDbTjgy9MYug gJGiqcIJ58d4FAFD85Ib0D5BjF8DaywKvn2wtf5CTMipRRJ8zLTfE0EJNur/TP3n OJOQSV5t7rhySJV9jCIsSkZkLiivAIXP89t5uZCgPQBkUWE+6lRFNKCojXaHRppI Y6K+nFoub0oP8o6YriosuHeJ26L2Z85yh6PH9uHOVB8mFs/lST9o2tJvsHBuinS7 gylxZzPIq9XYuIWmv5AxE6SP/K6MxRioDMvqXE5WkOEPeNHqZyO7Ad864Quuutba RvZrBq2MIfccz/XdCzgWM5MB3T8imDbOBpOTac0HzGNe8eipgG6oBb0Ho8GDL4ND RPL0dehXF+ZaGVhyRqXhFda2AfoAWiriHeizb7W1OBSwVNz3xd6ynblcoZdr7qx4 wpl2jDSUk2g8J75YjAaqhRqd5V0ahtyVs4xK5OioVUJ/IZ7lRcTEPCF0G5diUfpz wpTMT+YnUpWl1chxCtaux4mwZO9knNBdo/sNI1dXQvKnP6qC3GkYaIB8Z54xj9Qq AfCNXRJzrh6Uo96PK2Dl =ShlL -----END PGP SIGNATURE----- --sgneBHv3152wZ8jf--