From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Joe Perches <joe@perches.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: axp20x: Fix duplicate const for model names
Date: Mon, 30 Mar 2015 10:03:39 +0100 [thread overview]
Message-ID: <20150330090339.GU457@x1> (raw)
In-Reply-To: <1427192477-21843-1-git-send-email-k.kozlowski@samsung.com>
On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote:
> Replace duplicated const keyword for 'axp20x_model_names' with proper
> array of const pointers to const strings.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/axp20x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied thanks.
Joe,
Can I apply your Ack?
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 0acbe52b2411..1386826f713d 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -29,7 +29,7 @@
>
> #define AXP20X_OFF 0x80
>
> -static const char const *axp20x_model_names[] = {
> +static const char * const axp20x_model_names[] = {
> "AXP202",
> "AXP209",
> "AXP288",
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-03-30 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 10:21 [PATCH] mfd: axp20x: Fix duplicate const for model names Krzysztof Kozlowski
2015-03-24 13:53 ` Joe Perches
2015-03-24 14:06 ` Krzysztof Kozlowski
2015-03-30 9:03 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330090339.GU457@x1 \
--to=lee.jones@linaro.org \
--cc=joe@perches.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.