From: Peter Zijlstra <peterz@infradead.org>
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"riel@redhat.com" <riel@redhat.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"srikar@linux.vnet.ibm.com" <srikar@linux.vnet.ibm.com>,
"pjt@google.com" <pjt@google.com>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"efault@gmx.de" <efault@gmx.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
"svaidy@linux.vnet.ibm.com" <svaidy@linux.vnet.ibm.com>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
"jason.low2@hp.com" <jason.low2@hp.com>
Subject: Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs
Date: Mon, 30 Mar 2015 14:54:50 +0200 [thread overview]
Message-ID: <20150330125450.GL24151@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150330122449.GH21418@twins.programming.kicks-ass.net>
On Mon, Mar 30, 2015 at 02:24:49PM +0200, Peter Zijlstra wrote:
> @@ -7647,6 +7648,8 @@ static void nohz_idle_balance(struct rq *this_rq, enum cpu_idle_type idle)
> break;
>
> rq = cpu_rq(balance_cpu);
> + if (rq == this_rq)
> + done = true;
>
> /*
> * If time for next balance is due,
Equally note that if you change find_new_ilb() to not pick the very
first cpu in the mask you already get the bouncy bounce, because this
routine will in fact try and move things to the first cpu first.
So if you go change find_new_ilb() you should also amend the iteration
order here.
next prev parent reply other threads:[~2015-03-30 12:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 13:02 [PATCH V2] sched: Improve load balancing in the presence of idle CPUs Preeti U Murthy
2015-03-26 17:03 ` Jason Low
2015-03-27 2:12 ` Wanpeng Li
2015-03-27 4:33 ` Preeti U Murthy
2015-03-27 4:23 ` Wanpeng Li
2015-03-27 5:01 ` Jason Low
2015-03-27 5:07 ` Jason Low
2015-03-27 5:39 ` Srikar Dronamraju
2015-03-27 7:00 ` Wanpeng Li
2015-03-27 6:43 ` Wanpeng Li
2015-03-27 16:23 ` Preeti U Murthy
2015-03-27 11:43 ` [tip:sched/core] " tip-bot for Preeti U Murthy
2015-03-27 13:03 ` [PATCH V2] " Srikar Dronamraju
2015-03-27 14:38 ` Morten Rasmussen
2015-03-27 16:46 ` Preeti U Murthy
2015-03-27 17:56 ` Morten Rasmussen
2015-03-30 7:26 ` Preeti U Murthy
2015-03-30 11:30 ` Morten Rasmussen
2015-03-30 11:06 ` Peter Zijlstra
2015-03-30 12:03 ` Morten Rasmussen
2015-03-30 12:24 ` Peter Zijlstra
2015-03-30 12:54 ` Peter Zijlstra [this message]
2015-03-30 13:29 ` Vincent Guittot
2015-03-30 14:01 ` Peter Zijlstra
2015-03-30 15:27 ` Morten Rasmussen
2015-03-31 8:58 ` Preeti U Murthy
2015-03-31 17:30 ` Jason Low
2015-04-01 6:28 ` Preeti U Murthy
2015-04-01 13:03 ` Morten Rasmussen
2015-04-02 0:55 ` Jason Low
2015-04-02 3:22 ` Preeti U Murthy
2015-03-30 13:45 ` Vincent Guittot
2015-03-31 8:06 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330125450.GL24151@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=daniel.lezcano@linaro.org \
--cc=efault@gmx.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.