Re: [PATCH] tools/hvmloader: Don't perform AML hotplug debugging in production

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Mon, Mar 30, 2015 at 04:30:01PM +0100, Andrew Cooper wrote:
> On 30/03/15 16:22, Konrad Rzeszutek Wilk wrote:
> > On Mon, Mar 30, 2015 at 03:20:19PM +0100, Andrew Cooper wrote:
> >> It is number of vmexits and a moderate quantity of qemu logging which can
> >> safely be avoided when not specifically debugging a PCI hotplug issue.
> > Could we just make qemu-X not include this data when the we
> > run in production? And in the field if this needs to be diagnosed
> > we can just pass in an extra flag to QEMU and it would do it?
> 
> What do we not include?  This is data which gets bundled into hvmloader
> itself.
> 
> A little while ago, I proposed a different solution:
> 
> http://lists.xen.org/archives/html/xen-devel/2014-01/msg01526.html

.. in which I proposed an path that you had choosen in this patch.
> 
> which allowed this to all be controlled at runtime.  The important point
> is to avoid the vmexits if not needed, rather than to simply ignore the
> debugging they are giving.

<nods>

I know I've been using this in the field (so no need to deploy a
new build) - but then eventually I had to build an custom Xen binary.

Anyhow thank you for refreshing my memory on this patchset.

and in regards to the patch:
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> 
> ~Andrew