From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers Date: Mon, 30 Mar 2015 18:43:15 +0100 Message-ID: <20150330174315.GD15655@arm.com> References: <1427373799-18662-1-git-send-email-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1427373799-18662-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: Alexandre Courbot , "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Heiko Stuebner , Arnd Bergmann , Stephen Warren , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Kukjin Kim , Thierry Reding , "jroedel-l3A5Bk7waGM@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Yingjoe Chen , David Woodhouse , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: iommu@lists.linux-foundation.org Hi Joerg, On Thu, Mar 26, 2015 at 12:43:03PM +0000, Joerg Roedel wrote: > Changes v1-v2: > > * Rebased to v4.0-rc5 > * Converted domain-types to a bit-field > > Hi, > > here is patch-set to replace the existing domain_init and > domain_destroy iommu-ops with the new domain_alloc and > domain_free callbacks Whilst I'm still a bit worried about the ability of the IOMMU driver to do very much in the ->domain_alloc callback (since we don't know which IOMMU instance the domain is for), it doesn't leave us any worse off than we currently are. So, for the arm-smmu patch and the core IOMMU changes: Acked-by: Will Deacon Hopefully this doesn't conflict too badly with my outstanding arm-smmu pull requests to you, but do shout if you have any trouble. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 30 Mar 2015 18:43:15 +0100 Subject: [PATCH 00/16 v2] iommu: Move domain allocation into drivers In-Reply-To: <1427373799-18662-1-git-send-email-joro@8bytes.org> References: <1427373799-18662-1-git-send-email-joro@8bytes.org> Message-ID: <20150330174315.GD15655@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Joerg, On Thu, Mar 26, 2015 at 12:43:03PM +0000, Joerg Roedel wrote: > Changes v1-v2: > > * Rebased to v4.0-rc5 > * Converted domain-types to a bit-field > > Hi, > > here is patch-set to replace the existing domain_init and > domain_destroy iommu-ops with the new domain_alloc and > domain_free callbacks Whilst I'm still a bit worried about the ability of the IOMMU driver to do very much in the ->domain_alloc callback (since we don't know which IOMMU instance the domain is for), it doesn't leave us any worse off than we currently are. So, for the arm-smmu patch and the core IOMMU changes: Acked-by: Will Deacon Hopefully this doesn't conflict too badly with my outstanding arm-smmu pull requests to you, but do shout if you have any trouble. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753786AbbC3Rn0 (ORCPT ); Mon, 30 Mar 2015 13:43:26 -0400 Received: from foss.arm.com ([217.140.101.70]:33439 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519AbbC3RnV (ORCPT ); Mon, 30 Mar 2015 13:43:21 -0400 Date: Mon, 30 Mar 2015 18:43:15 +0100 From: Will Deacon To: Joerg Roedel Cc: "iommu@lists.linux-foundation.org" , Kukjin Kim , David Woodhouse , Heiko Stuebner , Hiroshi Doyu , Stephen Warren , Thierry Reding , Alexandre Courbot , Alex Williamson , Arnd Bergmann , Yingjoe Chen , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "jroedel@suse.de" Subject: Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers Message-ID: <20150330174315.GD15655@arm.com> References: <1427373799-18662-1-git-send-email-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427373799-18662-1-git-send-email-joro@8bytes.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, On Thu, Mar 26, 2015 at 12:43:03PM +0000, Joerg Roedel wrote: > Changes v1-v2: > > * Rebased to v4.0-rc5 > * Converted domain-types to a bit-field > > Hi, > > here is patch-set to replace the existing domain_init and > domain_destroy iommu-ops with the new domain_alloc and > domain_free callbacks Whilst I'm still a bit worried about the ability of the IOMMU driver to do very much in the ->domain_alloc callback (since we don't know which IOMMU instance the domain is for), it doesn't leave us any worse off than we currently are. So, for the arm-smmu patch and the core IOMMU changes: Acked-by: Will Deacon Hopefully this doesn't conflict too badly with my outstanding arm-smmu pull requests to you, but do shout if you have any trouble. Will