From: "Michael Büsch" <m@bues.ch>
To: Joe Perches <joe@perches.com>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 5/7] ssb: Use bool function return values of true/false not 1/0
Date: Mon, 30 Mar 2015 19:49:01 +0200 [thread overview]
Message-ID: <20150330194901.5293fbe2@wiggum> (raw)
In-Reply-To: <57da8293b865fb2d119e29073aec54323fc10000.1427736972.git.joe@perches.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Mon, 30 Mar 2015 10:43:21 -0700
Joe Perches <joe@perches.com> wrote:
> Use the normal return values for bool functions
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/ssb/driver_gige.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
> index e973405..ebee6b0 100644
> --- a/drivers/ssb/driver_gige.c
> +++ b/drivers/ssb/driver_gige.c
> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
> bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
> {
> if (!pdev->resource[0].name)
> - return 0;
> + return false;
> return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
> }
> EXPORT_SYMBOL(pdev_is_ssb_gige_core);
Looks good.
Signed-off-by: Michael Buesch <m@bues.ch>
Kalle, can you take this one, please?
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-30 17:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 17:43 [PATCH 0/7] drivers: Use bool function return values true/false not 1/0 Joe Perches
2015-03-30 17:43 ` [PATCH 1/7] drm: Use bool function return values of " Joe Perches
2015-03-30 17:43 ` Joe Perches
2015-03-30 17:43 ` [PATCH 2/7] dm_table: " Joe Perches
2015-03-30 17:51 ` Mike Snitzer
2015-03-30 17:43 ` [PATCH 3/7] genwqe: " Joe Perches
2015-03-30 17:43 ` [PATCH 4/7] wmi: " Joe Perches
2015-04-02 5:17 ` Darren Hart
2015-03-30 17:43 ` [PATCH 5/7] ssb: " Joe Perches
2015-03-30 17:49 ` Michael Büsch [this message]
2015-03-30 18:39 ` Kalle Valo
2015-03-30 17:43 ` [PATCH 6/7] thermal: " Joe Perches
2015-04-07 5:43 ` Zhang, Rui
2015-03-30 17:43 ` [PATCH 7/7] serial: kgdb_nmi: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330194901.5293fbe2@wiggum \
--to=m@bues.ch \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.