From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbbC3UnD (ORCPT ); Mon, 30 Mar 2015 16:43:03 -0400 Received: from mout.gmx.net ([212.227.17.22]:57223 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753515AbbC3UnA convert rfc822-to-8bit (ORCPT ); Mon, 30 Mar 2015 16:43:00 -0400 From: Peter =?iso-8859-15?q?H=FCwe?= To: Fabian Frederick Subject: Re: [PATCH 5/5 linux-next] tpm_ibmvtpm: remove unneccessary message level. Date: Mon, 30 Mar 2015 22:42:26 +0200 User-Agent: KMail/1.13.7 (Linux/3.19.2; KDE/4.14.3; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net References: <1427745969-12959-1-git-send-email-fabf@skynet.be> <1427745969-12959-5-git-send-email-fabf@skynet.be> In-Reply-To: <1427745969-12959-5-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Message-Id: <201503302242.45888.PeterHuewe@gmx.de> X-Provags-ID: V03:K0:dF8FlGkl2kgOJFm+5mrv83Nu8c1YuX7NLTzCzF37qjfKpjTC0kL hwRwXMd6hwOzCLDkm0Fm3p2RzqZ3bRwWMCKCEJUzG8akLShV3r4hPo1Wa8iMceg5zoStceg pWpydl1bmDGAQT3ck42Fptk7CztFevAXKkxbCxDGt5WZjrXOfDipUJJpS28xV0dtU1qSn8p Q9OUqMUMb1sEp1sMGvU/Q== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 30. März 2015, 22:06:08 schrieb Fabian Frederick: > KERN_ERR is implicitely declared in pr_err() > > Signed-off-by: Fabian Frederick Good catch. Acked-by: Peter Huewe If nobody else pulls this one through his tree, I'll apply it probably for 4._2_ (so it might take a while) Peter > --- > drivers/char/tpm/tpm_of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c > index c002d1b..eebe625 100644 > --- a/drivers/char/tpm/tpm_of.c > +++ b/drivers/char/tpm/tpm_of.c > @@ -49,7 +49,7 @@ int read_log(struct tpm_bios_log *log) > > basep = of_get_property(np, "linux,sml-base", NULL); > if (basep == NULL) { > - pr_err(KERN_ERR "%s: ERROR - SML not found\n", __func__); > + pr_err("%s: ERROR - SML not found\n", __func__); > goto cleanup_eio; > }