All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mesa3d: specify llvm-prefix
Date: Tue, 31 Mar 2015 11:25:25 +0200	[thread overview]
Message-ID: <20150331112525.5db42fa3@free-electrons.com> (raw)
In-Reply-To: <1427757360-20575-1-git-send-email-gustavo@zacarias.com.ar>

Dear Gustavo Zacarias,

On Mon, 30 Mar 2015 20:16:00 -0300, Gustavo Zacarias wrote:
> When it's not defined an automatic search is triggered, which can find
> /usr/bin/llvm-config on distributions that include all development files
> (like gentoo) and have desktop packages installed.
> So point it towards the staging dir which is where it should live
> eventually if/when we've got it to avoid header/include path polution
> that otherwise leads to build failures.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/mesa3d/mesa3d.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> index fc82227..7473110 100644
> --- a/package/mesa3d/mesa3d.mk
> +++ b/package/mesa3d/mesa3d.mk
> @@ -128,4 +128,7 @@ else
>  MESA3D_CONF_OPTS += --disable-gles1 --disable-gles2
>  endif
>  
> +# Avoid automatic search of llvm-config
> +MESA3D_CONF_OPTS += --with-llvm-prefix=$(STAGING_DIR)/usr/bin

Shouldn't we instead test if LLVM is available, explicitly disable LLVM
support if not, and enable it if LLVM is available?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-31  9:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 23:16 [Buildroot] [PATCH] mesa3d: specify llvm-prefix Gustavo Zacarias
2015-03-31  9:25 ` Thomas Petazzoni [this message]
2015-03-31 10:54   ` Gustavo Zacarias
2015-03-31 11:55     ` Thomas Petazzoni
2015-03-31 11:56       ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150331112525.5db42fa3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.