All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Alex Williamson
	<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Yingjoe Chen
	<yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jroedel-l3A5Bk7waGM@public.gmane.org
Subject: Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers
Date: Tue, 31 Mar 2015 15:14:41 +0200	[thread overview]
Message-ID: <20150331131441.GD4441@8bytes.org> (raw)
In-Reply-To: <1427516662.3643.906.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Hi Alex,

On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote:
> For 1-5,16
> 
> Reviewed-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Thanks a lot for your review.

> My only comment/question is whether you'd want to consider using
> ERR_PTR() return values from domain_alloc().  It's an alloc functions,
> so NULL == -ENOMEM is pretty standard, but we could at least have the
> interface to the iommu driver return more info even if we continue to
> mask that as NULL out to the IOMMU API users for now.  Thanks,

Yes, that might make sense. But to do anything useful with the ERR_PTR
we also need to change the iommu_domain_alloc() interface. This is
out-of-scope for this patch-set, we can discuss this seperatly.


	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/16 v2] iommu: Move domain allocation into drivers
Date: Tue, 31 Mar 2015 15:14:41 +0200	[thread overview]
Message-ID: <20150331131441.GD4441@8bytes.org> (raw)
In-Reply-To: <1427516662.3643.906.camel@redhat.com>

Hi Alex,

On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote:
> For 1-5,16
> 
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>

Thanks a lot for your review.

> My only comment/question is whether you'd want to consider using
> ERR_PTR() return values from domain_alloc().  It's an alloc functions,
> so NULL == -ENOMEM is pretty standard, but we could at least have the
> interface to the iommu driver return more info even if we continue to
> mask that as NULL out to the IOMMU API users for now.  Thanks,

Yes, that might make sense. But to do anything useful with the ERR_PTR
we also need to change the iommu_domain_alloc() interface. This is
out-of-scope for this patch-set, we can discuss this seperatly.


	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: iommu@lists.linux-foundation.org,
	Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Heiko Stuebner <heiko@sntech.de>, Hiroshi Doyu <hdoyu@nvidia.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
	jroedel@suse.de
Subject: Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers
Date: Tue, 31 Mar 2015 15:14:41 +0200	[thread overview]
Message-ID: <20150331131441.GD4441@8bytes.org> (raw)
In-Reply-To: <1427516662.3643.906.camel@redhat.com>

Hi Alex,

On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote:
> For 1-5,16
> 
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>

Thanks a lot for your review.

> My only comment/question is whether you'd want to consider using
> ERR_PTR() return values from domain_alloc().  It's an alloc functions,
> so NULL == -ENOMEM is pretty standard, but we could at least have the
> interface to the iommu driver return more info even if we continue to
> mask that as NULL out to the IOMMU API users for now.  Thanks,

Yes, that might make sense. But to do anything useful with the ERR_PTR
we also need to change the iommu_domain_alloc() interface. This is
out-of-scope for this patch-set, we can discuss this seperatly.


	Joerg


  parent reply	other threads:[~2015-03-31 13:14 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 12:43 [PATCH 00/16 v2] iommu: Move domain allocation into drivers Joerg Roedel
2015-03-26 12:43 ` Joerg Roedel
2015-03-26 12:43 ` [PATCH 15/16] iommu/fsl: Make use of domain_alloc and domain_free Joerg Roedel
2015-03-26 12:43   ` Joerg Roedel
     [not found]   ` <1427373799-18662-16-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-04-12 14:25     ` Varun Sethi
2015-04-12 14:25       ` Varun Sethi
2015-04-12 14:25       ` Varun Sethi
2015-03-26 12:43 ` [PATCH 16/16] iommu: Remove domain_init and domain_free iommu_ops Joerg Roedel
2015-03-26 12:43   ` Joerg Roedel
2015-03-27 11:03 ` [PATCH 00/16 v2] iommu: Move domain allocation into drivers Thierry Reding
2015-03-27 11:03   ` Thierry Reding
     [not found] ` <1427373799-18662-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-03-26 12:43   ` [PATCH 01/16] iommu: Introduce domain_alloc and domain_free iommu_ops Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 02/16] iommu: Introduce iommu domain types Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:52     ` Swapna Nannapaneni
2015-03-26 12:52       ` Swapna Nannapaneni
2015-03-26 12:52       ` Swapna Nannapaneni
2015-03-26 12:43   ` [PATCH 03/16] iommu: Only allow iommu_map/unmap for paging domains Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 04/16] iommu/amd: Make use of domain_alloc and domain_free Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 05/16] iommu/vt-d: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 06/16] iommu/omap: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 07/16] iommu/arm-smmu: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 08/16] iommu/exynos: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 09/16] iommu/tegra-smmu: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
     [not found]     ` <1427373799-18662-10-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-03-27 10:59       ` Thierry Reding
2015-03-27 10:59         ` Thierry Reding
2015-03-27 10:59         ` Thierry Reding
2015-03-26 12:43   ` [PATCH 10/16] iommu/tegra-gart: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
     [not found]     ` <1427373799-18662-11-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-03-27 11:00       ` Thierry Reding
2015-03-27 11:00         ` Thierry Reding
2015-03-27 11:00         ` Thierry Reding
2015-03-26 12:43   ` [PATCH 11/16] iommu/msm: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 12/16] iommu/shmobile: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 13/16] iommu/ipmmu-vmsa: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43   ` [PATCH 14/16] iommu/rockchip: " Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-26 12:43     ` Joerg Roedel
2015-03-27 16:39   ` [PATCH 00/16 v2] iommu: Move domain allocation into drivers Heiko Stuebner
2015-03-27 16:39     ` Heiko Stuebner
2015-03-27 16:39     ` Heiko Stuebner
2015-03-28  4:24   ` Alex Williamson
2015-03-28  4:24     ` Alex Williamson
2015-03-28  4:24     ` Alex Williamson
     [not found]     ` <1427516662.3643.906.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-31 13:14       ` Joerg Roedel [this message]
2015-03-31 13:14         ` Joerg Roedel
2015-03-31 13:14         ` Joerg Roedel
2015-03-30 17:43   ` Will Deacon
2015-03-30 17:43     ` Will Deacon
2015-03-30 17:43     ` Will Deacon
2015-03-31 13:18     ` Joerg Roedel
2015-03-31 13:18       ` Joerg Roedel
2015-03-31 13:33   ` Joerg Roedel
2015-03-31 13:33     ` Joerg Roedel
2015-03-31 13:33     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150331131441.GD4441@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jroedel-l3A5Bk7waGM@public.gmane.org \
    --cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    --cc=yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.