From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers Date: Tue, 31 Mar 2015 15:14:41 +0200 Message-ID: <20150331131441.GD4441@8bytes.org> References: <1427373799-18662-1-git-send-email-joro@8bytes.org> <1427516662.3643.906.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1427516662.3643.906.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex Williamson Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Will Deacon , Kukjin Kim , David Woodhouse , Heiko Stuebner , Hiroshi Doyu , Stephen Warren , Thierry Reding , Alexandre Courbot , Arnd Bergmann , Yingjoe Chen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jroedel-l3A5Bk7waGM@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Alex, On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote: > For 1-5,16 > > Reviewed-by: Alex Williamson Thanks a lot for your review. > My only comment/question is whether you'd want to consider using > ERR_PTR() return values from domain_alloc(). It's an alloc functions, > so NULL == -ENOMEM is pretty standard, but we could at least have the > interface to the iommu driver return more info even if we continue to > mask that as NULL out to the IOMMU API users for now. Thanks, Yes, that might make sense. But to do anything useful with the ERR_PTR we also need to change the iommu_domain_alloc() interface. This is out-of-scope for this patch-set, we can discuss this seperatly. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 From: joro@8bytes.org (Joerg Roedel) Date: Tue, 31 Mar 2015 15:14:41 +0200 Subject: [PATCH 00/16 v2] iommu: Move domain allocation into drivers In-Reply-To: <1427516662.3643.906.camel@redhat.com> References: <1427373799-18662-1-git-send-email-joro@8bytes.org> <1427516662.3643.906.camel@redhat.com> Message-ID: <20150331131441.GD4441@8bytes.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Alex, On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote: > For 1-5,16 > > Reviewed-by: Alex Williamson Thanks a lot for your review. > My only comment/question is whether you'd want to consider using > ERR_PTR() return values from domain_alloc(). It's an alloc functions, > so NULL == -ENOMEM is pretty standard, but we could at least have the > interface to the iommu driver return more info even if we continue to > mask that as NULL out to the IOMMU API users for now. Thanks, Yes, that might make sense. But to do anything useful with the ERR_PTR we also need to change the iommu_domain_alloc() interface. This is out-of-scope for this patch-set, we can discuss this seperatly. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584AbbCaNOs (ORCPT ); Tue, 31 Mar 2015 09:14:48 -0400 Received: from 8bytes.org ([81.169.241.247]:60990 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754563AbbCaNOo (ORCPT ); Tue, 31 Mar 2015 09:14:44 -0400 Date: Tue, 31 Mar 2015 15:14:41 +0200 From: Joerg Roedel To: Alex Williamson Cc: iommu@lists.linux-foundation.org, Will Deacon , Kukjin Kim , David Woodhouse , Heiko Stuebner , Hiroshi Doyu , Stephen Warren , Thierry Reding , Alexandre Courbot , Arnd Bergmann , Yingjoe Chen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, jroedel@suse.de Subject: Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers Message-ID: <20150331131441.GD4441@8bytes.org> References: <1427373799-18662-1-git-send-email-joro@8bytes.org> <1427516662.3643.906.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427516662.3643.906.camel@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote: > For 1-5,16 > > Reviewed-by: Alex Williamson Thanks a lot for your review. > My only comment/question is whether you'd want to consider using > ERR_PTR() return values from domain_alloc(). It's an alloc functions, > so NULL == -ENOMEM is pretty standard, but we could at least have the > interface to the iommu driver return more info even if we continue to > mask that as NULL out to the IOMMU API users for now. Thanks, Yes, that might make sense. But to do anything useful with the ERR_PTR we also need to change the iommu_domain_alloc() interface. This is out-of-scope for this patch-set, we can discuss this seperatly. Joerg