From: Ralf Baechle <ralf@linux-mips.org>
To: Mark Brown <broonie@kernel.org>
Cc: Bert Vermeulen <bert@biot.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, andy.shevchenko@gmail.com
Subject: Re: [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards
Date: Tue, 31 Mar 2015 16:22:47 +0200 [thread overview]
Message-ID: <20150331142247.GG28951@linux-mips.org> (raw)
In-Reply-To: <20150331084425.GI2869@sirena.org.uk>
On Tue, Mar 31, 2015 at 09:44:25AM +0100, Mark Brown wrote:
> On Mon, Mar 30, 2015 at 08:24:16PM +0200, Bert Vermeulen wrote:
> > Changes in v2:
> > This is a near complete rewrite of the original OpenWrt driver. All comments
> > were taken into account, and the spi_transfer.fast_write flag is gone.
> > Instead, the cs_change flag is used. It's not too bad a hack, as it really
> > does use CS.
>
> Don't send cover letters for single patches, if there's anything that
> needs saying it should either be in the changelog or after the ---. A
> separate cover letter adds to the mail volume and probably means that
> the patch itself is inadequately described.
My personal grief with cover letters is that patchwork only collects
patches but cover letters themselves aren't patches. Which means working
through patchwork I might miss important information. Maybe I should
request an enhancement to patchwork.
Ralf
prev parent reply other threads:[~2015-03-31 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 18:24 [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards Bert Vermeulen
2015-03-30 18:24 ` [PATCH v2 1/1] spi: Add SPI driver for Mikrotik RB4xx series boards Bert Vermeulen
2015-03-30 19:14 ` Andy Shevchenko
2015-03-30 19:14 ` Andy Shevchenko
2015-03-31 8:44 ` [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards Mark Brown
2015-03-31 8:44 ` Mark Brown
2015-03-31 14:22 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331142247.GG28951@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=andy.shevchenko@gmail.com \
--cc=bert@biot.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.