From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915: Convert BUGs to WARNs in the video overlay code
Date: Tue, 31 Mar 2015 17:59:17 +0300 [thread overview]
Message-ID: <20150331145916.GQ17410@intel.com> (raw)
In-Reply-To: <20150331122704.GI18595@nuc-i3427.alporthouse.com>
On Tue, Mar 31, 2015 at 01:27:04PM +0100, Chris Wilson wrote:
> On Tue, Mar 31, 2015 at 10:37:22AM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > BUG is bad, just use WARN.
> >
> > Also drop one BUG(!overlay) since we'd oops anyway when dereferencing
> > it.
>
> Bonus points for erroring out rather than continuing to nose dive into a
> crash. At least that way userspace should stop trying as well.
I have the feeling it shouldn't really blow up if we keep going in these
cases. I didn't do a very thorough analysis though.
I didn't want to start coding too defensively as there's practically no
limit on how far down that path we could go. So a line has to be drawn
somewhere.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-31 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 7:37 [PATCH 0/5] drm/i915: gen2 fixes ville.syrjala
2015-03-31 7:37 ` [PATCH 1/5] drm/i915: Enable DVO 2x clock around DVO encoder init ville.syrjala
2015-03-31 7:37 ` [PATCH 2/5] drm/i915: Convert BUGs to WARNs in the video overlay code ville.syrjala
2015-03-31 12:27 ` Chris Wilson
2015-03-31 14:59 ` Ville Syrjälä [this message]
2015-03-31 7:37 ` [PATCH 3/5] drm/i915: Convert overlay->{active, pfit_active} to bools ville.syrjala
2015-03-31 7:37 ` [PATCH 4/5] drm/i915: Mark the overlay active only if we got ring space ville.syrjala
2015-03-31 7:37 ` [PATCH 5/5] drm/i915: Enable mmeory self-refresh on 85x ville.syrjala
2015-03-31 11:14 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331145916.GQ17410@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.