From: Eddie Kovsky <ewk@edkovsky.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
rickard_strandqvist@spectrumdigital.se, c@24.io,
linux-kernel@vger.kernel.org, gdonald@gmail.com,
koray.gulcu@ozu.edu.tr, cristina.opriceana@gmail.com
Subject: Re: [PATCH V2] Staging: rtl8192 Clean up function definition
Date: Tue, 31 Mar 2015 13:25:02 -0600 [thread overview]
Message-ID: <20150331192502.GA28390@athena> (raw)
In-Reply-To: <20150331071454.GE10964@mwanda>
On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote:
> On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote:
> > Change function definition to static, move the function further up in
> > the file, and delete the function prototype.
> >
> > This fixes the following warning generated by sparse:
> >
> > drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol
> > 'rtl8192_update_ratr_table' was not declared. Should it be static?
> >
>
> Someone already fixed the warning earlier but this this is still a nice
> patch to have.
>
> regards,
> dan carpenter
Dan
I sent in the patch last week to fix this warning. You had asked me to
clean up the function by removing the prototype instead. Greg had
already sent me a message saying he picked up that patch. I waited a few
cycles, but I still haven't seen my patch show up in yesterday's (or
today's) next.
I assume my original patch got dropped waiting on this one?
Eddie
next prev parent reply other threads:[~2015-03-31 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 23:05 [PATCH V2] Staging: rtl8192 Clean up function definition Eddie Kovsky
2015-03-31 7:14 ` Dan Carpenter
2015-03-31 19:25 ` Eddie Kovsky [this message]
2015-04-01 7:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331192502.GA28390@athena \
--to=ewk@edkovsky.org \
--cc=c@24.io \
--cc=cristina.opriceana@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=koray.gulcu@ozu.edu.tr \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.