From: Alex Suykov <alex.suykov@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] batctl: fix musl builds
Date: Tue, 31 Mar 2015 22:50:55 +0300 [thread overview]
Message-ID: <20150331195055.GA2344@vostro> (raw)
In-Reply-To: <20150330231056.503b3c3d@free-electrons.com>
Mon, Mar 30, 2015 at 11:10:56PM +0200, Thomas Petazzoni wrote:
> > diff --git a/package/batctl/0001-musl-netinet.patch b/package/batctl/0001-musl-netinet.patch
>
> This patch is badly named: 0001-musl-netinet, while it also fixes
> things unrelated to netinet: the __be16/__be32 types. So either name it
> 0001-musl-fixes, or better maybe, split it in two patches.
Those are related changes actually. It looks like this:
linux/if_ether.h:
struct ethhdr { ... __be16 h_proto; }
netinet/if_ether.h (musl):
struct ethhdr { ... uint16_t h_proto; }
and that's where batctl code gets __be* types from if I got it right,
because it was written with linux/if_ether.h in mind.
Anyway, this is non-obvious and -musl-fixes.patch would work just as well,
so I'm sending v2 with the patch renamed.
> Also, can you submit the corresponding patches upstream?
No problem, patch sent upstream.
prev parent reply other threads:[~2015-03-31 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 17:04 [Buildroot] [PATCH] batctl: fix musl builds Alex Suykov
2015-03-30 21:10 ` Thomas Petazzoni
2015-03-31 19:50 ` Alex Suykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331195055.GA2344@vostro \
--to=alex.suykov@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.