From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id f5si565951wix.1.2015.03.31.20.01.25 for ; Tue, 31 Mar 2015 20:01:25 -0700 (PDT) Date: Wed, 1 Apr 2015 05:01:24 +0200 From: Alexandre Belloni To: Aaro Koskinen Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log Message-ID: <20150401030124.GO3849@piout.net> References: <1427576976-22353-1-git-send-email-aaro.koskinen@iki.fi> <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 28/03/2015 at 23:09:36 +0200, Aaro Koskinen wrote : > Use function name in the error log instead of __FILE__. > > Signed-off-by: Aaro Koskinen Acked-by: Alexandre Belloni > --- > drivers/rtc/hctosys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/hctosys.c b/drivers/rtc/hctosys.c > index 6c719f2..7748a61 100644 > --- a/drivers/rtc/hctosys.c > +++ b/drivers/rtc/hctosys.c > @@ -33,7 +33,7 @@ static int __init rtc_hctosys(void) > > if (rtc == NULL) { > pr_err("%s: unable to open rtc device (%s)\n", > - __FILE__, CONFIG_RTC_HCTOSYS_DEVICE); > + __func__, CONFIG_RTC_HCTOSYS_DEVICE); > goto err_open; > } > > -- > 2.2.0 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbbDADBa (ORCPT ); Tue, 31 Mar 2015 23:01:30 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45992 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751315AbbDADB0 (ORCPT ); Tue, 31 Mar 2015 23:01:26 -0400 Date: Wed, 1 Apr 2015 05:01:24 +0200 From: Alexandre Belloni To: Aaro Koskinen Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] rtc: hctosys: use function name in the error log Message-ID: <20150401030124.GO3849@piout.net> References: <1427576976-22353-1-git-send-email-aaro.koskinen@iki.fi> <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/03/2015 at 23:09:36 +0200, Aaro Koskinen wrote : > Use function name in the error log instead of __FILE__. > > Signed-off-by: Aaro Koskinen Acked-by: Alexandre Belloni > --- > drivers/rtc/hctosys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/hctosys.c b/drivers/rtc/hctosys.c > index 6c719f2..7748a61 100644 > --- a/drivers/rtc/hctosys.c > +++ b/drivers/rtc/hctosys.c > @@ -33,7 +33,7 @@ static int __init rtc_hctosys(void) > > if (rtc == NULL) { > pr_err("%s: unable to open rtc device (%s)\n", > - __FILE__, CONFIG_RTC_HCTOSYS_DEVICE); > + __func__, CONFIG_RTC_HCTOSYS_DEVICE); > goto err_open; > } > > -- > 2.2.0 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com